Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBREL]/Mitra/WEBREL-2753/ Remove the cryptocurrencies subheader #15312

Conversation

mitra-deriv
Copy link
Contributor

Changes:

As per figma design, in staging Cryptocurrencies subheading is not removed in the Account Creation modal while adding a real deriv account.

Screenshots:

image

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 22, 2024 3:42pm

Copy link
Contributor

github-actions bot commented May 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15312](https://github.com/binary-com/deriv-app/pull/15312)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mitra-deriv-remove-cryptocurrency-sub-header.binary.sx?qa_server=red.derivws.com&app_id=31468
    - **Original**: https://deriv-app-git-fork-mitra-deriv-remove-cryptocurrency-sub-header.binary.sx
- **App ID**: `31468`

Copy link
Contributor

github-actions bot commented May 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mitra-deriv-remove-cryptocurrency-sub-header.binary.sx/

is_fiat,
item_count,
description,
}: React.PropsWithChildren<TRadioButtonGroup>) => {
return (
<div className={className}>
{is_title_enabled && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see we have used this component in packages/core/src/App/Containers/RealAccountSignup/change-account-currency.jsx. with is_title_enabled as false. so with this change , this modal will effected. isnt?

Note: RadioButtonGroup component is used as CurrencyRadioButtonGroup outside accounts package
Screenshot 2024-05-22 at 7 34 11 PM

@coveralls
Copy link

Coverage Status

coverage: 42.481%. remained the same
when pulling 5392a55 on mitra-deriv:remove-cryptocurrency-sub-header
into d447edd on binary-com:master.

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mitra-deriv
Copy link
Contributor Author

Addressing the issue in #15316 closing this PR As I faced some issues on it locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants