Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suisin//upm819/phone verification flow #16141

Open
wants to merge 470 commits into
base: master
Choose a base branch
from
Open

Suisin//upm819/phone verification flow #16141

wants to merge 470 commits into from

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Phone Number Verification

Screenshots:

Screenshot 2024-07-22 at 11 31 12 AM

suisin-deriv and others added 30 commits July 2, 2024 11:18
@suisin-deriv
chore: update verify button to clear all possible stored value
0780939
@suisin-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into suisin/…
a22629f 
…utkarsha/UPM819/phone_verification_flow
@suisin-deriv
Merge branch 'suisin/utkarsha/UPM819/phone_verification_flow' of gith…
2713255 
…ub.com:suisin-deriv/deriv-app into suisin/UPM1058/api_integration_and_flows
@suisin-deriv
chore: update code to fix demo session bugs
1cf4917
@suisin-deriv
chore: remove is_mobile from ui-store and update to latest useDevice
6f23a09
@suisin-deriv
Merge pull request #100 from suisin-deriv/suisin/UPM1058/api_integrat…
c394c33 
…ion_and_flows

Suisin/upm1058/api integration and flows
@suisin-deriv
chore: fix test case failling and update code based on comments
2b7af0f
@suisin-deriv
chore: remove phone_number_verify?.verified logic check in personal d…
802d346 
…etails
@suisin-deriv
chore: fix test case and remove unused imports
80f9e5a
@suisin-deriv
chore: update to fix test case
ac1920c
@suisin-deriv
chore: update code based on comments
1164409
@suisin-deriv
chore: update test case
28eb67e
@suisin-deriv
chore: update code based on comments
6302e59
@suisin-deriv
chore: revert icons file
938259d
@suisin-deriv
chore: update code based on comments
0dcf055
@suisin-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into suisin/…
0fcbf35 
…utkarsha/UPM819/phone_verification_flow
@suisin-deriv
chore: update packages version and fix useSetting based on comments
f1a8fd0
@suisin-deriv
chore: update code based on comments
f7664ac
@suisin-deriv
chore: update verify-button.spec.tsx based on comment
5b70107
@suisin-deriv
chore: update quill-ui version and code based on comments
52049e3
@suisin-deriv
chore: update positions test case with scrollTo fix
a827578
@suisin-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into suisin/…
170d569 
…utkarsha/UPM819/phone_verification_flow
@suisin-deriv
chore: remove @ts-expected-error
f5f134d
@suisin-deriv
fix: console log verified not found issue and clear otp after click r…
f3c4b0c 
…esend code
@suisin-deriv
chore: fix authorize issue
bd0faa2
@suisin-deriv
chore: update quill-ui version for console log fix
3b4eee5
@suisin-deriv
chore: fix verification link expired rerendering issue
20afe67
@suisin-deriv
fix: clicks on resend link or send via whatsapp redirect user back to…
ab4e1e0 
… confirm phone number page
@suisin-deriv
chore: have to include color black in button so the underline will be…
5bfc199 
… black
@suisin-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into suisin/…
ebe39dd 
…utkarsha/UPM819/phone_verification_flow
@suisin-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into suisin/…
7d0c5f2 
…utkarsha/UPM819/phone_verification_flow
@suisin-deriv
Merge branch 'suisin/utkarsha/UPM819/phone_verification_flow' of gith…
4b38cb9 
…ub.com:suisin-deriv/deriv-app into suisin/utkarsha/UPM819/phone_verification_flow
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

⏳ Generating Lighthouse report...

amina-deriv and others added 2 commits September 18, 2024 14:14
@amina-deriv @yauheni-deriv @heorhi-deriv
update master (binary-com#16881)
6672c90 
* [UPM-1474]/evgeniy/passkey remove without verification (binary-com#16764)

* chore: [UPM-1474]/evgeniy/passkey remove without verification

* fix: import and typo

* fix: error modal overlapping, no paskey page show when no passkey after removing

* chore: test cases

* refactor: remove usequery from getpasskeys

* fix: failing test

* fix: failing tests

* fix: test

* fix: wrong condition to save empty passkey array

* feat(cashier): ✨ support crypto withdrawal transaction redirection from deriv go (binary-com#16802)

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com>
@suisin-deriv
Merge branch 'suisin/phone_number_verification' into suisin/utkarsha/…
fb39842 
…UPM819/phone_verification_flow
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasihali-deriv fasihali-deriv fasihali-deriv approved these changes

@amina-deriv amina-deriv amina-deriv left review comments

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv adrienne-deriv is a code owner

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv thisyahlen-deriv is a code owner

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv aizad-deriv is a code owner

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv heorhi-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suisin-deriv @coveralls @amina-deriv @fasihali-deriv