Amina/ fix: deriv-x password modal #16151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amina-deriv
commented
Jul 22, 2024
| if (url_action_param) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
This was added to move redundant modals. but removing this logic since appstore package have its own modal manger to trigger modals
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-webrel-3019fixpassword.binary.sx/ |
|
utkarsha-deriv
approved these changes
Jul 22, 2024
Dhruv-deriv
approved these changes
Jul 22, 2024
vinu-deriv
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix: password * chore: Empty-Commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
fix: deriv-x password modal
Screenshots:
Please provide some screenshots of the change.