Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amina/ fix: deriv-x password modal #16151

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Amina/ fix: deriv-x password modal #16151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a7db5
fix: password
amina-deriv Jul 22, 2024
29badd6
chore: Empty-Commit
amina-deriv Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/appstore/src/components/modals/modal-manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,6 @@ const ModalManager = () => {
is_mt5_password_invalid_format_modal_visible ||
is_sent_email_modal_enabled;

const url_params = new URLSearchParams(useLocation().search);
const url_action_param = url_params.get('action');
if (url_action_param) {
return null;
}

Copy link
Contributor Author

@amina-deriv amina-deriv Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to move redundant modals. but removing this logic since appstore package have its own modal manger to trigger modals

return (
<React.Fragment>
{is_jurisdiction_modal_visible && <JurisdictionModal openPasswordModal={openRealPasswordModal} />}
Expand Down