DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215

kate-deriv · 2024-07-26T07:04:32Z

Changes:

Allow equals:

Remove carousel component
Remove logic with saving user selection
Remove 'Save' button
Replace explanation text

Guide component:

Remove horizontal scrollbar (width should be 0) for IOS
Change paddings in trade type selection part

Extra:

Refactor Purchase button, based on comments
Update Quill UI version to the latest and remove TODO with associated task for InputField with numbers
Refactor tests

Screenshots:

vercel · 2024-07-26T07:04:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Jul 26, 2024 0:09am

github-actions · 2024-07-26T07:28:45Z

A production App ID was automatically generated for this PR. (log)

PR: DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-kate-deriv-kate-dtra-1542allowequalchanges.binary.sx?qa_server=red.derivws.com&app_id=24096
- Original: https://deriv-app-git-fork-kate-deriv-kate-dtra-1542allowequalchanges.binary.sx
App ID: 24096

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/16215](https://github.com/binary-com/deriv-app/pull/16215)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1542allowequalchanges.binary.sx?qa_server=red.derivws.com&app_id=24096
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1542allowequalchanges.binary.sx
- **App ID**: `24096`

github-actions · 2024-07-26T07:29:48Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	33
🟧 Accessibility	70
🟧 Best practices	83
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1542allowequalchanges.binary.sx/

coveralls · 2024-07-26T07:38:54Z

coverage: 46.228% (-0.002%) from 46.23%
when pulling d0defcf on kate-deriv:kate/DTRA-1542/allow_equal_changes
into 210a5bb on binary-com:master.

…lators" This reverts commit f0686ed.

kate-deriv · 2024-07-26T10:18:27Z

...es/trader/src/AppV2/Components/TradeParameters/LastDigitPrediction/last-digit-prediction.tsx

@@ -47,7 +46,7 @@ const LastDigitPrediction = observer(({ is_minimized, is_stats_mode }: TLastDigi
                            key={`last-digit-prediction${is_minimized ? '-minimized' : ''}`}
                        />
                    }
-                    value={last_digit.toString()} // TODO: remove toString after TextField supports a numeric 0 value in quill-ui


The issue was fixed in the latest quill version

kate-deriv · 2024-07-26T10:19:07Z

...es/trader/src/AppV2/Components/TradeParameters/LastDigitPrediction/last-digit-prediction.tsx

@@ -31,7 +31,6 @@ const LastDigitPrediction = observer(({ is_minimized, is_stats_mode }: TLastDigi
    };
    const onActionSheetClose = () => {
        setIsOpen(false);
-        //TODO: check if we need these 2 resets below after latest Quill Action sheet changes will be in our branch


I checked, it's not connected with quill, it's because state is stored in the parent. Hence, remove

sonarcloud · 2024-07-26T11:49:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-07-26T12:20:32Z

⏳ Generating Lighthouse report...

refactor: remove some tradr params for multipliers and accumulators

f0686ed

boring-cyborg bot added the Trader label Jul 26, 2024

kate-deriv temporarily deployed to Preview July 26, 2024 07:04 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 07:04 — with GitHub Actions View deployment

refactor: update quill and refactor purchase btn

a3cc84a

boring-cyborg bot added Account Core labels Jul 26, 2024

kate-deriv temporarily deployed to Preview July 26, 2024 07:59 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 08:00 — with GitHub Actions View deployment

refactor: allow equals

e0f890b

kate-deriv temporarily deployed to Preview July 26, 2024 08:57 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 08:57 — with GitHub Actions View deployment

kate-deriv added 2 commits July 26, 2024 12:55

refactor: guide style

250e388

Revert "refactor: remove some tradr params for multipliers and accumu…

4815cea

…lators" This reverts commit f0686ed.

kate-deriv temporarily deployed to Preview July 26, 2024 09:56 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 09:57 — with GitHub Actions View deployment

kate-deriv temporarily deployed to Preview July 26, 2024 09:57 — with GitHub Actions Inactive

kate-deriv temporarily deployed to Preview July 26, 2024 09:58 — with GitHub Actions Inactive

refactor: hide scrollbar for safari

34db8e8

kate-deriv temporarily deployed to Preview July 26, 2024 10:09 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 10:09 — with GitHub Actions View deployment

kate-deriv commented Jul 26, 2024

View reviewed changes

kate-deriv changed the title ~~DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes [WIP]~~ DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes Jul 26, 2024

kate-deriv marked this pull request as ready for review July 26, 2024 10:46

kate-deriv requested review from matin-deriv, maryia-deriv, ali-hosseini-deriv, amina-deriv, balakrishna-deriv, yashim-deriv and wojciech-deriv as code owners July 26, 2024 10:46

refactor: update type

4fa4a6b

kate-deriv temporarily deployed to Preview July 26, 2024 10:57 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 10:58 — with GitHub Actions View deployment

chore: remove px

d0defcf

kate-deriv temporarily deployed to Preview July 26, 2024 11:47 — with GitHub Actions Inactive

kate-deriv deployed to Preview July 26, 2024 11:47 — with GitHub Actions View deployment

maryia-deriv approved these changes Jul 26, 2024

View reviewed changes

vinu-deriv approved these changes Jul 26, 2024

View reviewed changes

balakrishna-deriv approved these changes Jul 29, 2024

View reviewed changes

balakrishna-deriv merged commit bce1cc1 into binary-com:master Jul 29, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215

DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215

kate-deriv commented Jul 26, 2024 •

edited

Loading

vercel bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

coveralls commented Jul 26, 2024 •

edited

Loading

kate-deriv Jul 26, 2024

kate-deriv Jul 26, 2024 •

edited

Loading

sonarcloud bot commented Jul 26, 2024

github-actions bot commented Jul 26, 2024

DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215

DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215

Conversation

kate-deriv commented Jul 26, 2024 • edited Loading

Changes:

Screenshots:

vercel bot commented Jul 26, 2024 • edited Loading

github-actions bot commented Jul 26, 2024 • edited Loading

github-actions bot commented Jul 26, 2024 • edited Loading

coveralls commented Jul 26, 2024 • edited Loading

kate-deriv Jul 26, 2024

Choose a reason for hiding this comment

kate-deriv Jul 26, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Jul 26, 2024

Quality Gate passed

github-actions bot commented Jul 26, 2024

kate-deriv commented Jul 26, 2024 •

edited

Loading

vercel bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

coveralls commented Jul 26, 2024 •

edited

Loading

kate-deriv Jul 26, 2024 •

edited

Loading