-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTRA / Kate / DTRA-1542 / [DTreader-V2]: Guide and Allow equal changes #16215
Merged
balakrishna-deriv
merged 8 commits into
binary-com:master
from
kate-deriv:kate/DTRA-1542/allow_equal_changes
Jul 29, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f0686ed
refactor: remove some tradr params for multipliers and accumulators
kate-deriv a3cc84a
refactor: update quill and refactor purchase btn
kate-deriv e0f890b
refactor: allow equals
kate-deriv 250e388
refactor: guide style
kate-deriv 4815cea
Revert "refactor: remove some tradr params for multipliers and accumu…
kate-deriv 34db8e8
refactor: hide scrollbar for safari
kate-deriv 4fa4a6b
refactor: update type
kate-deriv d0defcf
chore: remove px
kate-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
packages/trader/src/AppV2/Components/TradeParameters/AllowEquals/allow-equals-header.tsx
This file was deleted.
Oops, something went wrong.
9 changes: 3 additions & 6 deletions
9
packages/trader/src/AppV2/Components/TradeParameters/AllowEquals/allow-equals.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,16 @@ | ||
$HANDLEBAR_HEIGHT: var(--core-size-1000); | ||
$HEADER_TITLE_HEIGHT: var(--core-size-3200); | ||
$FOOTER_BUTTON_HEIGHT: var(--core-size-4000); | ||
|
||
.allow-equals { | ||
&__wrapper { | ||
height: calc(40dvh - $HANDLEBAR_HEIGHT - $HEADER_TITLE_HEIGHT - $FOOTER_BUTTON_HEIGHT); | ||
|
||
&--definition { | ||
height: calc(40dvh - $HANDLEBAR_HEIGHT - $HEADER_TITLE_HEIGHT); | ||
} | ||
height: calc(400px - $HANDLEBAR_HEIGHT - $HEADER_TITLE_HEIGHT); | ||
padding-block-start: 0; | ||
} | ||
|
||
&__content { | ||
display: flex; | ||
justify-content: space-between; | ||
align-items: center; | ||
padding-block: var(--core-spacing-400); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,6 @@ const LastDigitPrediction = observer(({ is_minimized, is_stats_mode }: TLastDigi | |
}; | ||
const onActionSheetClose = () => { | ||
setIsOpen(false); | ||
//TODO: check if we need these 2 resets below after latest Quill Action sheet changes will be in our branch | ||
setSelectedDigit(last_digit); | ||
}; | ||
|
||
|
@@ -47,7 +46,7 @@ const LastDigitPrediction = observer(({ is_minimized, is_stats_mode }: TLastDigi | |
key={`last-digit-prediction${is_minimized ? '-minimized' : ''}`} | ||
/> | ||
} | ||
value={last_digit.toString()} // TODO: remove toString after TextField supports a numeric 0 value in quill-ui | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue was fixed in the latest quill version |
||
value={last_digit} | ||
className={clsx('trade-params__option', 'trade-params__option--minimized')} | ||
onClick={() => setIsOpen(true)} | ||
/> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, it's not connected with quill, it's because state is stored in the parent. Hence, remove