Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maryia/Loading favicons based on size & excluded them from service worker #5063

Conversation

maryia-deriv-archive
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Loading favicons based on size & excluded them from service worker in order to not load any extra.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/jJ7Y9ZgvYE3TkP3UUM1Rrvdn6q5c
✅ Preview: https://deriv-app-git-fork-maryia-deriv-54892loadingextrafavicons.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5063](https://github.com/binary-com/deriv-app/pull/5063)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-54892loadingextrafavicons.binary.sx?qa_server=frontend.binaryws.com&app_id=24045
    - **Original**: https://deriv-app-git-fork-maryia-deriv-54892loadingextrafavicons.binary.sx
- **App ID**: `24045`

// })),
// ],
// append: false,
// });
Copy link
Contributor Author

@maryia-deriv-archive maryia-deriv-archive Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file are made just for consistency. generateSWConfig() and htmlInjectConfig() from this file are not used anywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not used, let's remove this, whole thing htmlInjectConfig()

Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@75b4a34). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5063   +/-   ##
=========================================
  Coverage          ?   12.16%           
=========================================
  Files             ?     1244           
  Lines             ?    28305           
  Branches          ?     4796           
=========================================
  Hits              ?     3442           
  Misses            ?    24633           
  Partials          ?      230           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b4a34...bb6eca0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants