-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maryia/Loading favicons based on size & excluded them from service worker #5172
Maryia/Loading favicons based on size & excluded them from service worker #5172
Conversation
…v/deriv-app into 54892_loading_extra_favicons
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-app/2CcRtvdUZbgMZoMiEH3quNbkKXNx |
already approved in #5063 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… from service worker (binary-com#5172)" (binary-com#5177)" (binary-com#5180) This reverts commit 699dc4a. Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change