Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maryia/Loading favicons based on size & excluded them from service worker #5180

Merged

Conversation

matin-deriv
Copy link
Contributor

Reverts #5177

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/BbNqL47zxPNfiUgK6AVUS6M5ntAh
✅ Preview: https://deriv-app-git-revert-5177-revert-5172-54892loadingextrafavicons.binary.sx

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #5180 (fc6e8ed) into master (77861e5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5180   +/-   ##
=======================================
  Coverage   13.32%   13.32%           
=======================================
  Files        1284     1284           
  Lines       29093    29093           
  Branches     4911     4911           
=======================================
  Hits         3876     3876           
  Misses      24979    24979           
  Partials      238      238           
Impacted Files Coverage Δ
packages/core/build/config.js 0.00% <0.00%> (ø)
packages/trader/build/config.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77861e5...fc6e8ed. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5180](https://github.com/binary-com/deriv-app/pull/5180)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-5177-revert-5172-54892loadingextrafavicons.binary.sx?qa_server=frontend.binaryws.com&app_id=31560
    - **Original**: https://deriv-app-git-revert-5177-revert-5172-54892loadingextrafavicons.binary.sx
- **App ID**: `31560`

@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 6:12AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farrah-deriv farrah-deriv merged commit a9203e4 into master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
… from service worker (binary-com#5172)" (binary-com#5177)" (binary-com#5180)

This reverts commit 699dc4a.

Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
@nijil-deriv nijil-deriv deleted the revert-5177-revert-5172-54892_loading_extra_favicons branch October 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants