-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suisin/Updated Sign up Modal Message #6126
Changes from 17 commits
cec1317
477c206
472d1c2
09aa272
4f87fef
326b427
d40d94f
9aac420
5967116
6759c17
93067f6
ad043c9
b91f4b7
78b77fe
29ffb77
a68f3a2
29c7600
2c11a85
f93bc1e
c7ed2ae
da23eec
9781817
c5d4aab
f8cfcf0
aabec76
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ const SameCitizenshipModal = ({ | |
}) => ( | ||
<div> | ||
<Text as='p' className='account-signup__text'> | ||
{localize('Are you a citizen of the same country where you live?')} | ||
{localize('Are you a citizen of {{- residence}}?', { residence })} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @suisin-deriv Just curious, What does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can check on this documentation @farzin-fs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @suisin-deriv Thank you 🙇🏻 |
||
</Text> | ||
<div className='account-signup__same-citizenship'> | ||
<Button | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are setting the active_index and input_value in the previous useEffect, isn't it better to add this condition to that useEffect instead of writing new one in order to not set those values twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try on that and see if it works. Thanks @mahdiyeh-fs 🙏