Suisin/Updated Sign up Modal Message #6126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
balakrishna-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Codecov Report
@@ Coverage Diff @@
## master #6126 +/- ##
==========================================
- Coverage 21.48% 21.47% -0.01%
==========================================
Files 1386 1386
Lines 31465 31473 +8
Branches 5363 5364 +1
==========================================
Hits 6760 6760
- Misses 24321 24329 +8
Partials 384 384
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jim-deriv
previously approved these changes
Aug 8, 2022
matin-deriv
reviewed
Aug 8, 2022
| }) => ( | ||
| <div> | ||
| <Text as='p' className='account-signup__text'> | ||
| {localize('Are you a citizen of the same country where you live?')} | ||
| {localize('Are you a citizen of ')} {selectedCountry}? |
There was a problem hiding this comment.
- Can you use
residencevalue? - You need to make sure selected country is being translated using
localize
…n-deriv/deriv-app into update_signup_pop_up_modal_message
…n-deriv/deriv-app into update_signup_pop_up_modal_message
mahdiyeh-deriv
previously approved these changes
Aug 9, 2022
yauheni-deriv
previously approved these changes
Aug 9, 2022
farzin-deriv
previously approved these changes
Aug 9, 2022
matin-deriv
previously approved these changes
Aug 10, 2022
farzin-deriv
previously approved these changes
Aug 11, 2022
mahdiyeh-deriv
previously approved these changes
Aug 11, 2022
hamid-deriv
previously approved these changes
Aug 11, 2022
hirad-deriv
previously approved these changes
Aug 11, 2022
suisin-deriv
dismissed stale reviews from hirad-deriv, hamid-deriv, mahdiyeh-deriv, farzin-deriv, and thisyahlen-deriv
via
a68f3a2
…signup_pop_up_modal_message
…n-deriv/deriv-app into update_signup_pop_up_modal_message
| @@ -70,6 +71,16 @@ const Autocomplete = React.memo(props => { | |||
| } | |||
| }, [list_items, has_updating_list]); | |||
|
|
|||
| React.useEffect(() => { | |||
There was a problem hiding this comment.
We are setting the active_index and input_value in the previous useEffect, isn't it better to add this condition to that useEffect instead of writing new one in order to not set those values twice?
There was a problem hiding this comment.
I'll try on that and see if it works. Thanks @mahdiyeh-fs 🙏
…signup_pop_up_modal_message
…n-deriv/deriv-app into update_signup_pop_up_modal_message
|
Kudos, SonarCloud Quality Gate passed!
|
hamid-deriv
approved these changes
Aug 15, 2022
mahdiyeh-deriv
approved these changes
Aug 15, 2022
farzin-deriv
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change