-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suisin/Updated Sign up Modal Message #6126
Merged
farrah-deriv
merged 25 commits into
binary-com:master
from
suisin-deriv:update_signup_pop_up_modal_message
Aug 29, 2022
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
cec1317
Updated Sign up Modal Message
suisin-deriv 477c206
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 472d1c2
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 09aa272
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 4f87fef
Updated Localize Value
suisin-deriv 326b427
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv d40d94f
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 9aac420
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 5967116
Remove selectedCountry
suisin-deriv 6759c17
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv 93067f6
resolved characters issue
suisin-deriv ad043c9
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv b91f4b7
Make Choose Country empty
suisin-deriv 78b77fe
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv 29ffb77
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv a68f3a2
Fixed Highlight Issue
suisin-deriv 29c7600
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 2c11a85
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv f93bc1e
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv c7ed2ae
Update highlight selection functions
suisin-deriv da23eec
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv 9781817
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv c5d4aab
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv f8cfcf0
Update function
suisin-deriv aabec76
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suisin-deriv Just curious, What does
-
do? 🤔 Couldn’t find anything on i18next doc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the
-
do is to set the escapeValue to false. Basically it will not convert the ' symbol into ASCII formatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can check on this documentation @farzin-fs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suisin-deriv Thank you 🙇🏻