Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/Updated Sign up Modal Message #6126

Merged
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
cec1317
Updated Sign up Modal Message
suisin-deriv Aug 8, 2022
477c206
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 8, 2022
472d1c2
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 8, 2022
09aa272
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 8, 2022
4f87fef
Updated Localize Value
suisin-deriv Aug 8, 2022
326b427
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv Aug 8, 2022
d40d94f
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 8, 2022
9aac420
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 9, 2022
5967116
Remove selectedCountry
suisin-deriv Aug 9, 2022
6759c17
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv Aug 9, 2022
93067f6
resolved characters issue
suisin-deriv Aug 10, 2022
ad043c9
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 10, 2022
b91f4b7
Make Choose Country empty
suisin-deriv Aug 11, 2022
78b77fe
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv Aug 11, 2022
29ffb77
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv Aug 11, 2022
a68f3a2
Fixed Highlight Issue
suisin-deriv Aug 15, 2022
29c7600
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 15, 2022
2c11a85
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv Aug 15, 2022
f93bc1e
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv Aug 15, 2022
c7ed2ae
Update highlight selection functions
suisin-deriv Aug 15, 2022
da23eec
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 15, 2022
9781817
Merge branch 'master' of github.com:binary-com/deriv-app into update_…
suisin-deriv Aug 15, 2022
c5d4aab
Merge branch 'update_signup_pop_up_modal_message' of github.com:suisi…
suisin-deriv Aug 15, 2022
f8cfcf0
Update function
suisin-deriv Aug 15, 2022
aabec76
Merge branch 'master' into update_signup_pop_up_modal_message
suisin-deriv Aug 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ const SameCitizenshipModal = ({
}) => (
<div>
<Text as='p' className='account-signup__text'>
{localize('Are you a citizen of the same country where you live?')}
{localize('Are you a citizen of {{- residence}}?', { residence })}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suisin-deriv Just curious, What does - do? 🤔 Couldn’t find anything on i18next doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the - do is to set the escapeValue to false. Basically it will not convert the ' symbol into ASCII format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can check on this documentation @farzin-fs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suisin-deriv Thank you 🙇🏻

</Text>
<div className='account-signup__same-citizenship'>
<Button
type='button'
onClick={() => {
setFieldValue('residence', null, false);
setIsSameCitizenshipModal(false);
}}
tertiary
Expand Down