Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/80792/playwright setup #7524

Merged

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

  • Playwright setup
  • Signup flow implementation
  • Remove Old End to end setup

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Docs label Feb 5, 2023
@vercel
Copy link

vercel bot commented Feb 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 8:00am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7524](https://github.com/binary-com/deriv-app/pull/7524)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-80792playwrigh-f2c31d.binary.sx?qa_server=red.binaryws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-80792playwrigh-f2c31d.binary.sx
- **App ID**: `32227`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 22
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-80792playwrigh-f2c31d.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@balakrishna-deriv
Copy link
Contributor

image

Can we cleanup QA wolf as part of this PR?

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #7524 (b7c0d00) into master (d7aaba9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #7524   +/-   ##
=======================================
  Coverage   20.74%   20.74%           
=======================================
  Files        1538     1538           
  Lines       35933    35928    -5     
  Branches     7030     7030           
=======================================
+ Hits         7453     7454    +1     
+ Misses      27733    27727    -6     
  Partials      747      747           
Impacted Files Coverage Δ
packages/core/build/constants.js 0.00% <0.00%> (ø)
packages/core/build/webpack.config.js 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yashim-deriv
yashim-deriv previously approved these changes Apr 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants