Sergei / 67781 / live chat color #7619

sergei-deriv · 2023-02-16T07:52:30Z

Changes:

Please include a summary of the change and which issue is fixed below:

add dark mode as query parameter for live-chat

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-02-16T07:52:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2023 11:44am

github-actions · 2023-02-16T08:04:09Z

A production App ID was automatically generated for this PR. (log)

PR: Sergei / 67781 / live chat color #7619
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-sergei-deriv-sergei-67781live-chat-color.binary.sx?qa_server=frontend.binaryws.com&app_id=31477
- Original: https://deriv-app-git-fork-sergei-deriv-sergei-67781live-chat-color.binary.sx
App ID: 31477

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/7619](https://github.com/binary-com/deriv-app/pull/7619)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-67781live-chat-color.binary.sx?qa_server=frontend.binaryws.com&app_id=31477
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-67781live-chat-color.binary.sx
- **App ID**: `31477`

github-actions · 2023-02-16T08:04:34Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-67781live-chat-color.binary.sx/

…e-chat-color

packages/core/src/App/Containers/Routes/routes.jsx

packages/core/src/App/Components/Elements/LiveChat/use-livechat.ts

packages/shared/src/utils/url/url.ts

codecov-commenter · 2023-02-24T09:38:06Z

Codecov Report

Merging #7619 (9f52a18) into master (9ecfe42) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #7619      +/-   ##
==========================================
- Coverage   20.73%   20.72%   -0.01%     
==========================================
  Files        1539     1539              
  Lines       35916    35925       +9     
  Branches     7012     7012              
==========================================
  Hits         7447     7447              
- Misses      27749    27758       +9     
  Partials      720      720

Impacted Files	Coverage Δ
...c/App/Components/Elements/LiveChat/use-livechat.ts	`0.00% <0.00%> (ø)`
packages/core/src/App/Containers/Routes/routes.jsx	`0.00% <0.00%> (ø)`
packages/shared/src/utils/url/url.ts	`29.34% <0.00%> (-3.19%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/core/src/App/Components/Elements/LiveChat/use-livechat.ts

The base branch was changed.

eduard-deriv · 2023-03-13T08:31:27Z

Lgtm!

yashim-deriv · 2023-03-23T06:14:19Z

packages/core/src/App/Components/Elements/LiveChat/use-livechat.ts

@@ -101,6 +102,10 @@ const useLiveChat = (has_cookie_account = false) => {
        });
    };

+    useEffect(() => {
+        onHistoryChange();
+    }, [search_params, onHistoryChange]);


i dont think useEffect will run on window.location.search since this is managed externally, outside of react. Can you replace with things in react-router?

@yashim-deriv I can change, no problem, but I've tested it and it works with window.location.search.

@yashim-deriv Changed to useParams(), pls check when you have time

…v/deriv-app into sergei/67781/live-chat-color

sonarcloud · 2023-04-07T11:37:55Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.6% Duplication

github-actions · 2023-04-07T12:01:44Z

⏳ Generating Lighthouse report...

This reverts commit 37e0d18.

feat: add query parameter for dark mode

3578324

boring-cyborg bot added Core Shared labels Feb 16, 2023

vercel bot deployed to Preview February 16, 2023 08:03 View deployment

sergei-deriv added 2 commits February 16, 2023 11:22

chore: empty to start build again

9b24a19

fix: update dark query parameter for every render

0b125f6

vercel bot deployed to Preview February 16, 2023 08:46 View deployment

feat: combine lang and dark query

ac2359a

vercel bot deployed to Preview February 16, 2023 11:34 View deployment

feat: change logic of getting lang_from_url in client-store

aa25f72

vercel bot deployed to Preview February 16, 2023 12:41 View deployment

feat: sort query parameters

f83acf6

vercel bot deployed to Preview February 16, 2023 13:24 View deployment

Merge remote-tracking branch 'upstream/develop' into sergei/67781/liv…

c02f799

…e-chat-color

boring-cyborg bot added the P2P label Feb 22, 2023

vercel bot deployed to Preview February 22, 2023 14:26 View deployment

feat: reinit livechat when query parameters change

596d683

vercel bot deployed to Preview February 22, 2023 15:01 View deployment

mahdiyeh-deriv previously approved these changes Feb 23, 2023

View reviewed changes

farzin-deriv reviewed Feb 24, 2023

View reviewed changes

refactor: apply Farzins suggestions

fea0c16

vercel bot deployed to Preview February 24, 2023 09:22 View deployment

farzin-deriv reviewed Feb 25, 2023

View reviewed changes

packages/core/src/App/Components/Elements/LiveChat/use-livechat.ts Outdated Show resolved Hide resolved

sergei-deriv changed the base branch from develop to master March 9, 2023 10:06

Merge branch 'master' into sergei/67781/live-chat-color

bc695e4

vercel bot deployed to Preview March 9, 2023 10:16 View deployment

eduard-deriv previously approved these changes Mar 13, 2023

View reviewed changes

feat: add search_params const

a896270

sergei-deriv dismissed eduard-deriv’s stale review via a896270 March 13, 2023 08:35

eduard-deriv previously approved these changes Mar 13, 2023

View reviewed changes

vercel bot deployed to Preview March 13, 2023 08:44 View deployment

yashim-deriv reviewed Mar 23, 2023

View reviewed changes

sergei-deriv and others added 3 commits March 23, 2023 02:38

Merge branch 'master' into sergei/67781/live-chat-color

5112399

feat: change window.location.search to useParams

42de21b

Merge branch 'sergei/67781/live-chat-color' of github.com:sergei-deri…

2410525

…v/deriv-app into sergei/67781/live-chat-color

sergei-deriv dismissed eduard-deriv’s stale review via 2410525 March 23, 2023 06:49

vercel bot deployed to Preview March 23, 2023 07:02 View deployment

Merge branch 'master' into sergei/67781/live-chat-color

1dd06e6

vercel bot deployed to Preview March 23, 2023 10:37 View deployment

mahdiyeh-deriv previously approved these changes Mar 29, 2023

View reviewed changes

Merge branch 'master' into sergei/67781/live-chat-color

67b1c65

sergei-deriv dismissed mahdiyeh-deriv’s stale review via 67b1c65 April 7, 2023 11:22

vercel bot deployed to Preview April 7, 2023 11:31 View deployment

refactor: delete empty lines

9f52a18

vercel bot deployed to Preview April 7, 2023 11:44 View deployment

eduard-deriv approved these changes May 2, 2023

View reviewed changes

mahdiyeh-deriv approved these changes May 2, 2023

View reviewed changes

sandeep-deriv merged commit 37e0d18 into binary-com:master May 3, 2023

hirad-deriv added a commit that referenced this pull request May 5, 2023

Revert "Sergei / 67781 / live chat color (#7619)"

0fa214d

This reverts commit 37e0d18.

hirad-deriv mentioned this pull request May 5, 2023

Revert "Sergei / 67781 / live chat color" #8473

Merged

hirad-deriv added a commit that referenced this pull request May 5, 2023

Revert "Sergei / 67781 / live chat color (#7619)" (#8473)

8a4fec1

This reverts commit 37e0d18.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sergei / 67781 / live chat color #7619

Sergei / 67781 / live chat color #7619

sergei-deriv commented Feb 16, 2023 •

edited

Loading

vercel bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

codecov-commenter commented Feb 24, 2023 •

edited

Loading

eduard-deriv commented Mar 13, 2023

yashim-deriv Mar 23, 2023

sergei-deriv Mar 23, 2023

sergei-deriv Mar 23, 2023

sonarcloud bot commented Apr 7, 2023

github-actions bot commented Apr 7, 2023

Sergei / 67781 / live chat color #7619

Sergei / 67781 / live chat color #7619

Conversation

sergei-deriv commented Feb 16, 2023 • edited Loading

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Feb 16, 2023 • edited Loading

github-actions bot commented Feb 16, 2023 • edited Loading

github-actions bot commented Feb 16, 2023 • edited Loading

codecov-commenter commented Feb 24, 2023 • edited Loading

Codecov Report

eduard-deriv commented Mar 13, 2023

yashim-deriv Mar 23, 2023

Choose a reason for hiding this comment

sergei-deriv Mar 23, 2023

Choose a reason for hiding this comment

sergei-deriv Mar 23, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Apr 7, 2023

github-actions bot commented Apr 7, 2023

sergei-deriv commented Feb 16, 2023 •

edited

Loading

vercel bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

codecov-commenter commented Feb 24, 2023 •

edited

Loading