-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sergei / 67781 / live chat color #7619
Merged
sandeep-deriv
merged 17 commits into
binary-com:master
from
sergei-deriv:sergei/67781/live-chat-color
May 3, 2023
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3578324
feat: add query parameter for dark mode
sergei-deriv 9b24a19
chore: empty to start build again
sergei-deriv 0b125f6
fix: update dark query parameter for every render
sergei-deriv ac2359a
feat: combine lang and dark query
sergei-deriv aa25f72
feat: change logic of getting lang_from_url in client-store
sergei-deriv f83acf6
feat: sort query parameters
sergei-deriv c02f799
Merge remote-tracking branch 'upstream/develop' into sergei/67781/liv…
sergei-deriv 596d683
feat: reinit livechat when query parameters change
sergei-deriv fea0c16
refactor: apply Farzins suggestions
sergei-deriv bc695e4
Merge branch 'master' into sergei/67781/live-chat-color
sergei-deriv a896270
feat: add search_params const
sergei-deriv 5112399
Merge branch 'master' into sergei/67781/live-chat-color
sergei-deriv 42de21b
feat: change window.location.search to useParams
sergei-deriv 2410525
Merge branch 'sergei/67781/live-chat-color' of github.com:sergei-deri…
sergei-deriv 1dd06e6
Merge branch 'master' into sergei/67781/live-chat-color
sergei-deriv 67b1c65
Merge branch 'master' into sergei/67781/live-chat-color
sergei-deriv 9f52a18
refactor: delete empty lines
sergei-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think useEffect will run on
window.location.search
since this is managed externally, outside of react. Can you replace with things inreact-router
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashim-deriv I can change, no problem, but I've tested it and it works with
window.location.search
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashim-deriv Changed to useParams(), pls check when you have time