henry/91709/test: add test coverage for poi unsupported #8041

henry-deriv · 2023-03-28T02:25:43Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-03-28T02:25:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2023 5:12pm

github-actions · 2023-03-28T02:37:17Z

A production App ID was automatically generated for this PR. (log)

PR: henry/91709/test: add test coverage for poi unsupported #8041
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-henry-deriv-henry-91709test-coverage-0af783.binary.sx?qa_server=red.binaryws.com&app_id=32850
- Original: https://deriv-app-git-fork-henry-deriv-henry-91709test-coverage-0af783.binary.sx
App ID: 32850

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8041](https://github.com/binary-com/deriv-app/pull/8041)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-91709test-coverage-0af783.binary.sx?qa_server=red.binaryws.com&app_id=32850
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-91709test-coverage-0af783.binary.sx
- **App ID**: `32850`

github-actions · 2023-03-28T02:37:39Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-91709test-coverage-0af783.binary.sx/

codecov-commenter · 2023-03-28T02:43:40Z

Codecov Report

Merging #8041 (7aa0fdf) into master (b27de39) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8041   +/-   ##
=======================================
  Coverage   20.07%   20.07%           
=======================================
  Files        1827     1827           
  Lines       41459    41459           
  Branches     8240     8240           
=======================================
+ Hits         8321     8323    +2     
+ Misses      32278    32276    -2     
  Partials      860      860

see 1 file with indirect coverage changes

…oi-unsupported-failed

sonarcloud · 2023-04-04T03:33:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-06-04T00:25:37Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

…1709/test-coverage-for-poi-unsupported-failed

gitguardian · 2023-06-05T06:52:15Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`f7b0122`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`f7b0122`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

…ted-failed

sonarcloud · 2023-06-18T16:59:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-06-18T17:22:45Z

⏳ Generating Lighthouse report...

DerivFE · 2023-06-19T06:44:52Z

✨ PR has been merged by Paimon the Release Bot

* synchronize amount inputs, add transfer button (WALL-554) with test link (binary-com#8962) * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (binary-com#34) * fix: update padding of app-icon component (binary-com#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: ✨ synchronize amount inputs, add transfer button * perf: refactor code * refactor: remove listener, add onScroll to mobile_dialog, remove ref from mobile_dialog * fix: apply comments * fix: reset amount_to if selected transfer_from is a wallet * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (binary-com#34) * fix: update padding of app-icon component (binary-com#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: name visibility after closing the modal * perf: improve transition behaviour * test: fix tests * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: add missing code * refactor: apply comments * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * refactor: roll back Tab component * style: fix style for merged icon * fix: mock loginid * fix: mock account loginid * fix: typo, demo icon * fix: typo, demo icon, transition on closing, blinking icons --------- Co-authored-by: Hamid <hamid@regentmarkets.com> * chore: disable PT (binary-com#9021) * Fix: leave confirm tests failed (binary-com#9030) * fix: leave-confirm tests failed * refactor: modify usestate spyOn function * refactor: add more coverage * Adrienne / Release automation integration (binary-com#8914) * feat: added release automation workflow * chore: added config for first merge * chore: renamed first merge delay config * feat: added configuration to skip updating base branch * feat: added option for maximum tasks * chore: skip slack integration * chore: enabled github integration * chore: updated fe-toolbox version * chore: removed platform input * chore: updated refetch limit * chore: added gitguardian to skip checks * chore: fixed syntax issue * chore: added new lines at bottom * fix: fix wrong branch name (binary-com#9037) * henry/91713/test: Test coverage for POO statuses components (binary-com#8125) * test: Test coverage for POO statuses components * fix: Empty-Commit --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/91709/test: add test coverage for poi unsupported (binary-com#8041) * test: add test coverage * test: switch from regex to string * fix: change test coverage --------- Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/dtra-131/feat: dropdown style and description change for all trade types (binary-com#8727) * feat: dropdown style and description change for all trade types * fix: minify svg * refactor: resolve edge cases * fix: remove comment * fix: resolve comments * fix: add animation, make image scrollable * refactor: refactor for better maintainability * fix: circleci issue * fix: disable animation for now * fix: indexing to contract type value and change view height for mobile * fix: remove outerscroll * fix: trying auto size * fix: autosizer didnt work * fix: make words bold * fix: fix bold * fix: remove navigation and pagnation * fix: refactor * fix: resolve comments * empty commit * empty commit * fix: rearrange glossary based on order * fix: animation bug * fix: disable swipe on mobile and animation issue * fix: remove commented out code * fix: scroll not working for trade-types * fix: test * fix: remove unintended test file * Kate / DTRA-202 / Apply new style to the trade type menu in mobile (binary-com#8931) * fix: remove special style from trade type menu in mobile * chore: change trade type text * fix: remove Change password text for DMT5 (binary-com#8927) * fix: remove Change password text for DMT5 * chore: empty commit --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/91133/refactor: Refactored, migrated to TS and added test cases (binary-com#7998) * refactor: Refactored, migrated to TS and added test cases * fix: circleCI issue * fix: circle CI issue * fix: codecov rerun commit * fix: all test cases covered * fix: make props reusable * Merge branch 'master' of github.com:binary-com/deriv-app into henry/91133/Refactor-ServicesErrorModal --------- Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * chore: increase workers for jest (binary-com#8954) * chore: increase workers for jest * ci: change codecov command * ci: update codecov command * ci: update codecov command * ci: reduce number of workers for codecov * ci: change workers to 4 for codecov * ci: remove duplicate command * ci: update default value --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * farabi/bot-324/remove-security-and-privacy-from-dbot-footer (binary-com#8825) * fix: removed security and privacy from dbot footer * fix: removed icons commit --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * Jim/FEQ-147/e2e-test-cases-for-traders-hub-dashboard (binary-com#8649) * feat: initial e2e * chore: remove package-lock * chore: restore original code * chore: use chromium as the only browser for testing * docs: update description for the command to show the test report in dev mode * ci: add command to show the tests report in dev mode * test: update test case to use count * refactor: extract text to constant variables and add whitespace --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * refactor 🔧: Aum / WALL-297 / deposit fiat module (binary-com#8938) * feat: created deposit-fiat-module * chore: applied changes from comments * refactor: moved dark-mode logic from deposit-fiat-iframe to useDepositFiatAddress hook * feat: added test for useDepositFiatAddress hook * feat: added test cases for light and dark theme for iframe url * chore: removed unused import for Real.tsx in Deposit.tsx * chore: removed test case for Real.tsx in deposit.spec.tsx * chore: minor change * chore: empty-commit --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * farabi/bot-124/update-stop-loss-and-take-profit-content (binary-com#8953) * fix: update content of take profit and stop loss * chore: redeploy * chore: redeploy * fix: adjust backward compatibility to support legacy bots (binary-com#8925) * chore: Rename the Other CFDS on Onboarding and Trader Hubs Homepage (binary-com#8975) * chore: Rename the Other CFDS on Onboarding and Trader Hubs Homepage * chore: empty commit * fix: update eu disclaimer percentage (binary-com#8361) * Suisin/chore: add thai language into deriv app (binary-com#8766) * chore: add thai language into deriv app * chore: added Thai language check for Thai --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * farabi/bot-315/dbot-to-deriv-bot (binary-com#8955) * fix: rebrand dbot to deriv bot * chore: added test case for tour trigger dialog * feat: added wallets notifications to wallets (binary-com#8837) * feat: added wallets notifications to wallets * fix: remove commentted code * fix: show notifications for platforms only * fix: change label on CTA * fix: added hooks package * fix: update branch * translations: 📚 sync translations with crowdin (binary-com#9058) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * henry/fix: dtrader translation issue (binary-com#9062) * fix: dtrader translation issue * fix: translation issues * translations: 📚 sync translations with crowdin (binary-com#9063) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (binary-com#9065) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (binary-com#9066) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * test: add tests --------- Co-authored-by: Hamid <hamid@regentmarkets.com> Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>

test: add test coverage

8525051

henry-deriv requested a review from yashim-deriv as a code owner March 28, 2023 02:25

boring-cyborg bot added the Account label Mar 28, 2023

vercel bot deployed to Preview March 28, 2023 02:36 View deployment

henry-deriv force-pushed the henry/91709/test-coverage-for-poi-unsupported-failed branch from 9e71ae4 to 8525051 Compare March 28, 2023 03:04

test: switch from regex to string

bd4720d

vercel bot deployed to Preview March 28, 2023 03:16 View deployment

Merge branch 'binary-com:master' into henry/91709/test-coverage-for-p…

ded51e9

…oi-unsupported-failed

vercel bot deployed to Preview April 2, 2023 00:07 View deployment

Merge branch 'binary-com:master' into henry/91709/test-coverage-for-p…

4b2a6e0

…oi-unsupported-failed

vercel bot deployed to Preview April 4, 2023 00:58 View deployment

fix: change test coverage

3d75155

vercel bot deployed to Preview April 4, 2023 03:43 View deployment

github-actions bot added the Stale label Jun 4, 2023

yauheni-deriv approved these changes Jun 5, 2023

View reviewed changes

heorhi-deriv approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'master' of github.com:binary-com/deriv-app into henry/9…

f7b0122

…1709/test-coverage-for-poi-unsupported-failed

vercel bot deployed to Preview June 5, 2023 07:09 View deployment

likhith-deriv approved these changes Jun 5, 2023

View reviewed changes

github-actions bot removed the Stale label Jun 6, 2023

Merge branch 'master' into henry/91709/test-coverage-for-poi-unsuppor…

7aa0fdf

…ted-failed

vercel bot deployed to Preview June 18, 2023 17:12 View deployment

DerivFE merged commit 49ffe5a into binary-com:master Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

henry/91709/test: add test coverage for poi unsupported #8041

henry/91709/test: add test coverage for poi unsupported #8041

henry-deriv commented Mar 28, 2023

vercel bot commented Mar 28, 2023 •

edited

Loading

github-actions bot commented Mar 28, 2023 •

edited

Loading

github-actions bot commented Mar 28, 2023 •

edited

Loading

codecov-commenter commented Mar 28, 2023 •

edited by codecov bot

Loading

sonarcloud bot commented Apr 4, 2023

github-actions bot commented Jun 4, 2023

gitguardian bot commented Jun 5, 2023 •

edited

Loading

sonarcloud bot commented Jun 18, 2023

github-actions bot commented Jun 18, 2023

DerivFE commented Jun 19, 2023

henry/91709/test: add test coverage for poi unsupported #8041

henry/91709/test: add test coverage for poi unsupported #8041

Conversation

henry-deriv commented Mar 28, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Mar 28, 2023 • edited Loading

github-actions bot commented Mar 28, 2023 • edited Loading

github-actions bot commented Mar 28, 2023 • edited Loading

codecov-commenter commented Mar 28, 2023 • edited by codecov bot Loading

Codecov Report

sonarcloud bot commented Apr 4, 2023

github-actions bot commented Jun 4, 2023

gitguardian bot commented Jun 5, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

sonarcloud bot commented Jun 18, 2023

github-actions bot commented Jun 18, 2023

DerivFE commented Jun 19, 2023

vercel bot commented Mar 28, 2023 •

edited

Loading

github-actions bot commented Mar 28, 2023 •

edited

Loading

github-actions bot commented Mar 28, 2023 •

edited

Loading

codecov-commenter commented Mar 28, 2023 •

edited by codecov bot

Loading

gitguardian bot commented Jun 5, 2023 •

edited

Loading