refactor 🔧: Aum / WALL-297 / deposit fiat module #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aum-deriv
changed the title
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-297deposit-fiat-module.binary.sx/ |
farzin-deriv
reviewed
Jun 8, 2023
...ges/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.scss
Outdated
Show resolved
Hide resolved
...ges/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.scss
Outdated
Show resolved
Hide resolved
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Outdated
Show resolved
Hide resolved
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Outdated
Show resolved
Hide resolved
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Outdated
Show resolved
Hide resolved
…tFiatAddress hook
farzin-deriv
reviewed
Jun 8, 2023
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Outdated
Show resolved
Hide resolved
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Outdated
Show resolved
Hide resolved
...ages/cashier/src/modules/deposit-fiat/components/deposit-fiat-iframe/deposit-fiat-iframe.tsx
Show resolved
Hide resolved
…L-297/deposit-fiat-module
farzin-deriv
previously approved these changes
Jun 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #8938 +/- ##
==========================================
+ Coverage 20.07% 20.10% +0.03%
==========================================
Files 1827 1830 +3
Lines 41459 41480 +21
Branches 8240 8244 +4
==========================================
+ Hits 8321 8338 +17
- Misses 32278 32281 +3
- Partials 860 861 +1
|
…L-297/deposit-fiat-module
heorhi-deriv
approved these changes
Jun 9, 2023
…L-297/deposit-fiat-module
farzin-deriv
approved these changes
Jun 14, 2023
…L-297/deposit-fiat-module
aum-deriv
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
|
✨ PR has been merged by Paimon the Release Bot |
heorhi-deriv
added a commit
to rostislav-deriv/deriv-app
that referenced
this pull request
Jun 22, 2023
* synchronize amount inputs, add transfer button (WALL-554) with test link (binary-com#8962) * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (binary-com#34) * fix: update padding of app-icon component (binary-com#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: ✨ synchronize amount inputs, add transfer button * perf: refactor code * refactor: remove listener, add onScroll to mobile_dialog, remove ref from mobile_dialog * fix: apply comments * fix: reset amount_to if selected transfer_from is a wallet * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (binary-com#34) * fix: update padding of app-icon component (binary-com#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: name visibility after closing the modal * perf: improve transition behaviour * test: fix tests * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: add missing code * refactor: apply comments * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * refactor: roll back Tab component * style: fix style for merged icon * fix: mock loginid * fix: mock account loginid * fix: typo, demo icon * fix: typo, demo icon, transition on closing, blinking icons --------- Co-authored-by: Hamid <hamid@regentmarkets.com> * chore: disable PT (binary-com#9021) * Fix: leave confirm tests failed (binary-com#9030) * fix: leave-confirm tests failed * refactor: modify usestate spyOn function * refactor: add more coverage * Adrienne / Release automation integration (binary-com#8914) * feat: added release automation workflow * chore: added config for first merge * chore: renamed first merge delay config * feat: added configuration to skip updating base branch * feat: added option for maximum tasks * chore: skip slack integration * chore: enabled github integration * chore: updated fe-toolbox version * chore: removed platform input * chore: updated refetch limit * chore: added gitguardian to skip checks * chore: fixed syntax issue * chore: added new lines at bottom * fix: fix wrong branch name (binary-com#9037) * henry/91713/test: Test coverage for POO statuses components (binary-com#8125) * test: Test coverage for POO statuses components * fix: Empty-Commit --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/91709/test: add test coverage for poi unsupported (binary-com#8041) * test: add test coverage * test: switch from regex to string * fix: change test coverage --------- Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/dtra-131/feat: dropdown style and description change for all trade types (binary-com#8727) * feat: dropdown style and description change for all trade types * fix: minify svg * refactor: resolve edge cases * fix: remove comment * fix: resolve comments * fix: add animation, make image scrollable * refactor: refactor for better maintainability * fix: circleci issue * fix: disable animation for now * fix: indexing to contract type value and change view height for mobile * fix: remove outerscroll * fix: trying auto size * fix: autosizer didnt work * fix: make words bold * fix: fix bold * fix: remove navigation and pagnation * fix: refactor * fix: resolve comments * empty commit * empty commit * fix: rearrange glossary based on order * fix: animation bug * fix: disable swipe on mobile and animation issue * fix: remove commented out code * fix: scroll not working for trade-types * fix: test * fix: remove unintended test file * Kate / DTRA-202 / Apply new style to the trade type menu in mobile (binary-com#8931) * fix: remove special style from trade type menu in mobile * chore: change trade type text * fix: remove Change password text for DMT5 (binary-com#8927) * fix: remove Change password text for DMT5 * chore: empty commit --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * henry/91133/refactor: Refactored, migrated to TS and added test cases (binary-com#7998) * refactor: Refactored, migrated to TS and added test cases * fix: circleCI issue * fix: circle CI issue * fix: codecov rerun commit * fix: all test cases covered * fix: make props reusable * Merge branch 'master' of github.com:binary-com/deriv-app into henry/91133/Refactor-ServicesErrorModal --------- Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * chore: increase workers for jest (binary-com#8954) * chore: increase workers for jest * ci: change codecov command * ci: update codecov command * ci: update codecov command * ci: reduce number of workers for codecov * ci: change workers to 4 for codecov * ci: remove duplicate command * ci: update default value --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * farabi/bot-324/remove-security-and-privacy-from-dbot-footer (binary-com#8825) * fix: removed security and privacy from dbot footer * fix: removed icons commit --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * Jim/FEQ-147/e2e-test-cases-for-traders-hub-dashboard (binary-com#8649) * feat: initial e2e * chore: remove package-lock * chore: restore original code * chore: use chromium as the only browser for testing * docs: update description for the command to show the test report in dev mode * ci: add command to show the tests report in dev mode * test: update test case to use count * refactor: extract text to constant variables and add whitespace --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * refactor 🔧: Aum / WALL-297 / deposit fiat module (binary-com#8938) * feat: created deposit-fiat-module * chore: applied changes from comments * refactor: moved dark-mode logic from deposit-fiat-iframe to useDepositFiatAddress hook * feat: added test for useDepositFiatAddress hook * feat: added test cases for light and dark theme for iframe url * chore: removed unused import for Real.tsx in Deposit.tsx * chore: removed test case for Real.tsx in deposit.spec.tsx * chore: minor change * chore: empty-commit --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * farabi/bot-124/update-stop-loss-and-take-profit-content (binary-com#8953) * fix: update content of take profit and stop loss * chore: redeploy * chore: redeploy * fix: adjust backward compatibility to support legacy bots (binary-com#8925) * chore: Rename the Other CFDS on Onboarding and Trader Hubs Homepage (binary-com#8975) * chore: Rename the Other CFDS on Onboarding and Trader Hubs Homepage * chore: empty commit * fix: update eu disclaimer percentage (binary-com#8361) * Suisin/chore: add thai language into deriv app (binary-com#8766) * chore: add thai language into deriv app * chore: added Thai language check for Thai --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * farabi/bot-315/dbot-to-deriv-bot (binary-com#8955) * fix: rebrand dbot to deriv bot * chore: added test case for tour trigger dialog * feat: added wallets notifications to wallets (binary-com#8837) * feat: added wallets notifications to wallets * fix: remove commentted code * fix: show notifications for platforms only * fix: change label on CTA * fix: added hooks package * fix: update branch * translations: 📚 sync translations with crowdin (binary-com#9058) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * henry/fix: dtrader translation issue (binary-com#9062) * fix: dtrader translation issue * fix: translation issues * translations: 📚 sync translations with crowdin (binary-com#9063) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (binary-com#9065) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (binary-com#9066) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * test: add tests --------- Co-authored-by: Hamid <hamid@regentmarkets.com> Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.