-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaheer/Suisin/Amina/feature/90115/update jurisdiction #8093
Changes from 250 commits
2c1da0a
a365912
a9bac37
35ad751
94d6b60
a4b0c42
53c5add
7d751a4
259f48a
50f1c2d
869a7a6
66a26ad
7409988
7f7fac2
b37583c
524dceb
2d9afde
592a9a4
c23e84b
533606f
4bab9ff
bf8d3b4
b3fcdbc
e0ecd30
3c25502
034aefd
8e0e6af
e72b4d6
ce65b71
2053456
7478cef
6ef14bd
9533259
ff565a4
2bb3eec
fde6d0e
d6536d0
6c3f5c9
f2cf54b
879660f
1d15b9e
f2ecb34
1714a78
4f73b31
2aea226
68b8d54
77e505f
ae3e07d
92b77f6
7c441a1
5e5302b
8f38263
a6a5236
79d7d75
62fb1e3
a5fa344
d4c8658
07611c4
2507582
5b9ef6a
a5d3aa7
f881a59
191c651
1ba5b58
7e675ed
ba98ede
a38613f
e07216c
2d3226c
3a8d812
c68bc20
6937c6d
abe12fa
e316a16
acba460
4350d5b
dcf07ab
eb87804
c19a9ec
1b02756
db96606
6deebf8
3674ee9
fe991a2
cba7745
8d31b16
749659a
fd7e75b
e738b91
6cb80d6
7d6c87a
5183e24
46cab5a
ec0109e
4ecc32d
cb425dd
b26250d
5bb8c8a
13d65a0
da90022
3b6a6a0
69f7cd1
8e0ab0a
ae445fc
8e3b66d
3bb0da5
dc88aed
c0d8b24
9aa892a
9658700
3be6fed
22dd454
ee7b488
0e6edc6
f1b61bb
db89e7f
48ee27b
4dc36fa
d8f7683
7689a63
83b784f
e59ab35
5005abb
5464453
a747e0f
c599e65
18057c6
406b9d3
cec8896
4c070dc
2257fb5
0a91fd9
ae2b971
50069cf
b5b57c8
76947b0
1c491a5
8365d5f
071ce45
875850e
5b15629
5e60bd9
1ad0572
87bcb02
39a96c6
de37b21
883a181
fbd75c9
0000ffc
f3525bf
b6881c7
7870b2e
b323bf7
5bf9d35
22972df
99392b9
7a5ec10
5ba7aa9
8f66bd0
8509055
6704425
dd53ac7
e8df579
29f2f5f
292ad69
cd15c91
ee1b487
7c1945c
3310b4a
f382e2b
171c00a
8969de4
e91936a
b3d969b
1d81ab3
c6ef3c4
d7eab5c
eb28654
5fdb287
c3dcc98
8c76e17
5f3e3ab
47ba18c
1f7afc8
16ca57c
6300d90
2946ebd
b8f2181
ff5aae2
08a75e3
f6d637b
54bdd0e
6f6835e
6f7faa0
0c1d868
d54f2e5
732d91b
eb68da8
823cb70
3260f4f
b4b7d27
c419119
6a71fbe
67979f0
a81c74d
58f5c18
fd8b8c3
26ace1d
5e22832
c14323d
e5b1c3a
2585e53
4abb87b
c0e77e4
7da2544
de97112
4e38fd6
202d61b
601cecf
4e7a608
bfb7363
0db522f
c9b1044
946731a
ff677f5
322d6cc
79fb4d0
68d3b28
f876202
b1034dd
74e753c
960d85b
3c8cb72
2311678
47c7b2f
8d19714
47d9077
7223b71
75bef86
ea8ac5d
d2b543e
8ce4136
974aa5a
f8d3f10
dd30695
da0279d
227267b
4ecb467
c66f332
a06ddb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,8 +26,8 @@ describe('<CurrencySelector/>', () => { | |
is_virtual: 1, | ||
landing_company_shortcode: 'virtual', | ||
trading: {}, | ||
token: 'a1-sLGGrhfYPkeEprxEop2T591cLKbuN', | ||
email: 'test+qw@deriv.com', | ||
token: '', | ||
email: '', | ||
session_start: 1651059038, | ||
excluded_until: '', | ||
landing_company_name: 'virtual', | ||
|
@@ -273,8 +273,8 @@ describe('<CurrencySelector/>', () => { | |
is_virtual: 1, | ||
landing_company_shortcode: 'svg', | ||
trading: {}, | ||
token: 'a1-sLGGrhfYPkeEprxEop2T591cLKbuN', | ||
email: 'test+qw@deriv.com', | ||
token: '', | ||
email: '', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these part of this PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @amina-deriv there were no changes to currency selector. could you please try pulling latest master? |
||
session_start: 1651059038, | ||
excluded_until: '', | ||
landing_company_name: 'svg', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/* eslint-disable react-hooks/exhaustive-deps */ | ||
import React from 'react'; | ||
import { WS } from '@deriv/shared'; | ||
import { WS, Jurisdiction } from '@deriv/shared'; | ||
import Unsupported from 'Components/poi/status/unsupported'; | ||
import OnfidoUpload from './onfido-sdk-view.jsx'; | ||
import { identity_status_codes, submission_status_code, service_code } from './proof-of-identity-utils'; | ||
|
@@ -30,7 +30,7 @@ const POISubmissionForMT5 = ({ | |
is_idv_supported && | ||
Number(idv_submissions_left) > 0 && | ||
!is_idv_disallowed && | ||
jurisdiction_selected_shortcode !== 'vanuatu' | ||
jurisdiction_selected_shortcode !== Jurisdiction.VANUATU | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have 25.5% duplication. I suggest you create an improvement card to fix this issue later. Other than that everything LGTM. |
||
) { | ||
setSubmissionService(service_code.idv); | ||
} else if (onfido_submissions_left && is_onfido_supported) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have 5 codesmells in your PR. You can forget about Cognitive Complexities but others need to get fixed.