Shaheer/Suisin/Amina/feature/90115/update jurisdiction

[amina-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• ...

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2023 9:05am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Shaheer/Suisin/Amina/feature/90115/update jurisdiction #8093
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-amina-deriv-amina-feature90115updatej-bf5bc3.binary.sx?qa_server=red.binaryws.com&app_id=32112
  • Original: https://deriv-app-git-fork-amina-deriv-amina-feature90115updatej-bf5bc3.binary.sx
• App ID: 32112

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8093](https://github.com/binary-com/deriv-app/pull/8093)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-feature90115updatej-bf5bc3.binary.sx?qa_server=red.binaryws.com&app_id=32112
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-feature90115updatej-bf5bc3.binary.sx
- **App ID**: `32112`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-feature90115updatej-bf5bc3.binary.sx/

[codecov-commenter]

Codecov Report

Merging #8093 (a06ddb9) into master (1da4c97) will increase coverage by 0.43%.
The diff coverage is 45.21%.

@@            Coverage Diff             @@
##           master    #8093      +/-   ##
==========================================
+ Coverage   19.21%   19.64%   +0.43%     
==========================================
  Files        1799     1811      +12     
  Lines       41031    41033       +2     
  Branches     8139     8140       +1     
==========================================
+ Hits         7883     8062     +179     
+ Misses      32339    32155     -184     
- Partials      809      816       +7     

Impacted Files	Coverage Δ
.../poi-poa-docs-submitted/poi-poa-docs-submitted.tsx	0.00% <0.00%> (ø)
...fIdentity/proof-of-identity-submission-for-mt5.jsx	0.00% <ø> (ø)
...ackages/cfd/src/Containers/cfd-dbvi-onboarding.tsx	0.00% <0.00%> (ø)
...ction-modal/jurisdiction-modal-content-wrapper.tsx	0.00% <0.00%> (ø)
...ntainers/jurisdiction-modal/jurisdiction-modal.tsx	0.00% <0.00%> (ø)
...s/cfd/src/Containers/mt5-compare-table-content.tsx	0.00% <0.00%> (ø)
...s/cfd/src/Stores/Modules/CFD/Helpers/cfd-config.ts	78.78% <ø> (ø)
packages/cfd/src/Stores/Modules/CFD/cfd-store.js	10.00% <0.00%> (+10.00%)	⬆️
packages/cfd/src/Containers/cfd-password-modal.tsx	70.66% <35.71%> (+0.13%)	⬆️
...ntainers/cfd-financial-stp-real-account-signup.tsx	55.55% <66.66%> (-0.81%)	⬇️
... and 17 more

... and 3 files with indirect coverage changes

[gitguardian]

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	dd53ac7	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	dd53ac7	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	cd15c91	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	cd15c91	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	2946ebd	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	2946ebd	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[amina-deriv]

Are these part of this PR?

[shaheer-deriv]

@amina-deriv there were no changes to currency selector. could you please try pulling latest master?

[amina-deriv]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
1.9% Duplication