Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mingw support to conan-gtest #166

Closed
sourcedelica opened this issue Mar 8, 2018 · 5 comments
Closed

Add mingw support to conan-gtest #166

sourcedelica opened this issue Mar 8, 2018 · 5 comments

Comments

@sourcedelica
Copy link

Description of Problem, Request, or Question

Package Details (Include if Applicable)

  • Package Name/Version: gtest/1.8.0
  • Operating System: Windows Mingw
  • Compiler+version: gcc

Steps to reproduce (Include if Applicable)

  1. Try to create gtest package using Mingw.
  2. Compilation fails with error messages like:
[ 12%] Building CXX object source_subfolder/googlemock/gtest/CMakeFiles/gtest.dir/src/gtest-all.cc.obj
In file included from C:/Users/epederson/.conan/data/gtest/1.8.0/bincrafters/stable/build/a8137cc68f43291a51999b4b5805900a416debac/source_subfolder/googletest/include/gtest/internal/gtest-internal.h:40:0,
                 from C:/Users/epederson/.conan/data/gtest/1.8.0/bincrafters/stable/build/a8137cc68f43291a51999b4b5805900a416debac/source_subfolder/googletest/include/gtest/gtest.h:58,
                 from C:/Users/epederson/.conan/data/gtest/1.8.0/bincrafters/stable/build/a8137cc68f43291a51999b4b5805900a416debac/source_subfolder/googletest/src/gtest-all.cc:39:
C:/Users/epederson/.conan/data/gtest/1.8.0/bincrafters/stable/build/a8137cc68f43291a51999b4b5805900a416debac/source_subfolder/googletest/include/gtest/internal/gtest-port.h:1782:3: error: 'AutoHandle' does not name a type
   AutoHandle thread_;
   ^~~~~~~~~~
@sourcedelica
Copy link
Author

sourcedelica commented Mar 9, 2018

Hi Dimi -

I fixed it in the PR bincrafters/conan-gtest#10.

The fix is based on the answer in google/googletest#606 (comment).

It builds properly on Mingw with this fix.

@ghost
Copy link

ghost commented Mar 14, 2018

I had noticed that's why I deleted my message (sorry). So listen, this all looks good to me now. It's just that I don't have rights to accept the pull request myself. If someone who does can do it, that would be great 😄

@SSE4
Copy link
Member

SSE4 commented Apr 20, 2018

@dimi309 seems like PR has been accepted, anything else to be done here?

@ghost
Copy link

ghost commented Apr 20, 2018

I don't think so. It looks good to me...

@SSE4
Copy link
Member

SSE4 commented Apr 20, 2018

closing out as PR has been accepted. @sourcedelica if you have any other problem(s) with MinGW build of GTest, feel free to open new issue(s).

@SSE4 SSE4 closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants