-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mingw support to conan-gtest #166
Comments
Hi Dimi - I fixed it in the PR bincrafters/conan-gtest#10. The fix is based on the answer in google/googletest#606 (comment). It builds properly on Mingw with this fix. |
I had noticed that's why I deleted my message (sorry). So listen, this all looks good to me now. It's just that I don't have rights to accept the pull request myself. If someone who does can do it, that would be great 😄 |
@dimi309 seems like PR has been accepted, anything else to be done here? |
I don't think so. It looks good to me... |
closing out as PR has been accepted. @sourcedelica if you have any other problem(s) with MinGW build of GTest, feel free to open new issue(s). |
Description of Problem, Request, or Question
Package Details (Include if Applicable)
Steps to reproduce (Include if Applicable)
The text was updated successfully, but these errors were encountered: