Skip to content
This repository has been archived by the owner on Sep 21, 2019. It is now read-only.

Set gtest_disable_pthreads for mingw #10

Conversation

sourcedelica
Copy link
Contributor

@SSE4 SSE4 requested a review from a user March 9, 2018 08:48
@SSE4 SSE4 assigned ghost Mar 13, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks! This also eliminates the advantage v1.7.0 had over v1.8.0, namely that v1.8.0 couldn't be compiled with MinGW. Btw, about your comment on using subsystems, personally I prefer NOT to use them, unless I actually find a difference between them that blocks compilation. So I think the conanfile is great as it is, without subsystems. Of course, I am not sure that everyone agrees with this.

@solvingj
Copy link
Member

Thanks for digging into this @sourcedelica . For now, i'm not comfortable with the debugger stuff. If we need a feature like that, we should look into getting it added to conan as a native feature somehow. This one is also in conan-center, so we should only apply changes that are really needed and well-tested.

Also, I'm going to ask Conan team to look at the subsystem stuff to see if there's anything we can do better in that regard. Please stand by.

Also, pls drop the gitignore change.

@sourcedelica
Copy link
Contributor Author

Done

.idea/ is created by the Pycharm IDE. It's pretty popular so I'd recommend that we allow it in .gitignore. Otherwise those files can get accidentally committed.

@uilianries uilianries merged commit 4025858 into bincrafters:testing/1.8.0 Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants