upd orthologer to 3.4.2 #51128
upd orthologer to 3.4.2 #51128
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/orthologer/meta.yaml (1)
Line range hint
1-67: Consider updating the build number.The package has been successfully updated from version 3.4.1 to 3.4.2, with appropriate changes to the checksum, summary, and metadata. However, I noticed that the
buildnumber has not been reset to 0. It's a best practice to reset the build number to 0 when updating the package version.Please consider applying the following change:
build: - number: 0 + number: 0 # Reset to 0 for new versionAlso, please ensure that the dependencies and test commands are still valid for the new version. If any changes are needed, please update them accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/orthologer/meta.yaml (3 hunks)
🔇 Additional comments (4)
recipes/orthologer/meta.yaml (4)
2-3: LGTM: Version and checksum updated correctly.The version has been updated to 3.4.2 as per the PR objective, and the SHA256 checksum has been updated accordingly. This change is correct and necessary for the package update.
54-54: LGTM: Summary updated to better reflect package functionality.The summary has been updated from "Assessment of assembly completeness using Universal Single Copy Orthologs" to "Find orthologous genes as well as mapping to OrthoDB." This new description provides a more accurate representation of the package's functionality.
66-67: LGTM: DOI and PMID identifiers added.The addition of DOI (10.1093/nar/gkac996) and PMID (36350662) identifiers is a good improvement to the package metadata. These likely refer to a publication related to the software.
To verify these identifiers, you can run the following script:
#!/bin/bash # Description: Verify the DOI and PMID identifiers # Test: Check if the DOI resolves correctly curl -sI "https://doi.org/10.1093/nar/gkac996" | grep -i "HTTP/2 200" # Test: Check if the PMID is valid curl -s "https://eutils.ncbi.nlm.nih.gov/entrez/eutils/esummary.fcgi?db=pubmed&id=36350662" | grep -q "<Id>36350662</Id>"This script will verify that the DOI resolves correctly and that the PMID is valid. Please review the output to confirm the identifiers are correct.
51-52: Verify the license change from MIT to GPL3.The license has been changed from MIT to GPL3. This is a significant change that may affect how users can use and distribute the software. Please confirm that this change is intentional and aligns with the upstream project's licensing.
To verify this change, you can run the following script:
This script will download the source package and extract the LICENSE file. Please review the output to confirm the GPL3 license.
Update orthologer to 3.4.2.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
New Features
Versioning
Licensing