pretextgraph: add aarch64/arm64 builds #51710
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added
aarch64
|
Warning Rate limit exceeded@martin-g has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to two files: Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
recipes/pretextgraph/build.sh (1)
Line range hint
6-8: Consider making compiler selection consistent.The script uses default compiler on Darwin but explicitly uses clang on other platforms. Consider documenting why different compiler selections are used, or make it consistent across platforms if possible.
Also applies to: 9-9
🧰 Tools
🪛 Shellcheck
[warning] 5-5: Quote this to prevent word splitting.
(SC2046)
recipes/pretextgraph/meta.yaml (2)
43-43: Add newline at end of fileAdd a newline character at the end of the file to comply with YAML best practices.
- osx-arm64 +🧰 Tools
🪛 yamllint
[error] 43-43: no new line character at the end of file
(new-line-at-end-of-file)
Based on the search results, I can generate the final response as we found relevant evidence about clang version requirements for aarch64 in other recipes.
Update clang version requirement for aarch64 compatibility
Other recipes in the codebase specifically require clang 16 for aarch64 builds:
recipes/devider/meta.yaml: uses clang >=16,<17 for aarch64recipes/get_mnv/meta.yaml: uses clang >=16,<17 for aarch64The current requirement of clang 11.0.1 appears to be outdated and may not provide optimal support for aarch64 builds. Consider updating to match the version requirements used by other packages.
🔗 Analysis chain
Line range hint
21-23: Verify clang version compatibility for aarch64Please verify that clang/clang++ 11.0.1 is sufficient for building on aarch64 architecture. Some ARM-specific optimizations might benefit from newer versions.
Consider adding a comment in the recipe explaining the minimum clang version requirement for aarch64 builds.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any specific clang version requirements in similar aarch64 packages rg -l "clang.*aarch64" | xargs rg "clang.*>="Length of output: 191
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/pretextgraph/build.sh (1 hunks)
- recipes/pretextgraph/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/pretextgraph/meta.yaml
[error] 43-43: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (4)
recipes/pretextgraph/build.sh (2)
3-3: LGTM! Enhanced debugging capability added.Adding
-xto the set options is a good practice for cross-platform builds as it helps with troubleshooting by showing each command before execution.
Line range hint
5-13: Verify ARM64 build configuration.The build script uses meson which supports cross-compilation, but let's verify the build configuration for ARM64 platforms.
🧰 Tools
🪛 Shellcheck
[warning] 5-5: Quote this to prevent word splitting.
(SC2046)
recipes/pretextgraph/meta.yaml (2)
14-14: LGTM: Build number increment is appropriateThe build number increment is correct as we're adding new platform builds while keeping the same package version.
40-43: LGTM: Platform additions are well-specifiedThe addition of
linux-aarch64andosx-arm64platforms is correctly configured and aligns with the PR objective to support ARM64 architecture.🧰 Tools
🪛 yamllint
[error] 43-43: no new line character at the end of file
(new-line-at-end-of-file)
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
... because it just works Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.