-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gxf2bed: add aarch64/arm64 builds #51120
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/gxf2bed/build.sh (1)
6-6
: Improvedcargo install
command with debugging supportThe modifications to the
cargo install
command are beneficial:
- Adding
RUST_BACKTRACE=1
enables full backtraces, which is excellent for debugging potential issues.- The
--no-track
option is appropriate for Conda build environments where the installation directory may be temporary.These changes, combined with the removal of previous workarounds, suggest an improved and more standardized build process.
Consider adding a comment explaining the purpose of
--no-track
for future maintainers:# build statically linked binary with Rust -RUST_BACKTRACE=1 cargo install --verbose --path . --root ${PREFIX} --no-track +# Use --no-track to prevent Cargo from tracking the installation in its local tracking file +RUST_BACKTRACE=1 cargo install --verbose --path . --root ${PREFIX} --no-track
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/gxf2bed/build.sh (1 hunks)
- recipes/gxf2bed/meta.yaml (2 hunks)
🔇 Additional comments (6)
recipes/gxf2bed/build.sh (2)
3-3
: Excellent addition ofset -xe
The inclusion of
set -xe
is a great improvement to the script. It enables verbose execution (-x
) which aids in debugging, and causes the script to exit immediately if any command fails (-e
), preventing potential cascading errors. This change aligns with best practices for robust shell scripting.
1-6
: Overall improvements support aarch64/arm64 buildsThe changes to this build script are well-aligned with the PR's objective of adding aarch64/arm64 builds:
- The script has been simplified by removing previous workarounds, suggesting an improved build environment.
- The addition of
set -xe
andRUST_BACKTRACE=1
enhances debugging capabilities, which is crucial when supporting new architectures.- The use of
--no-track
withcargo install
is appropriate for Conda build environments.Importantly, these improvements are architecture-agnostic, maintaining good maintainability while supporting the new builds. The script is now more robust and easier to debug across all supported architectures.
recipes/gxf2bed/meta.yaml (4)
13-13
: LGTM: Build number increment is correct.Incrementing the build number from 0 to 1 is the right approach when making changes to the package without updating its version. This follows Conda packaging best practices.
36-38
: LGTM: Additional platforms added correctly.The addition of
linux-aarch64
andosx-arm64
to theadditional-platforms
list is correct and aligns with the PR objectives. This change will enable the package to be built and used on ARM-based systems, increasing its accessibility.To ensure full compatibility with these new architectures, please verify that:
- The package builds successfully on these new platforms.
- All dependencies are available for these architectures.
You can use the following command to check if there are any architecture-specific build issues:
#!/bin/bash # Description: Check build logs for any architecture-specific issues gh run list --limit 1 --json conclusion,url --jq '.[] | select(.conclusion == "success") | .url' | xargs -I {} gh run view {} --log | grep -E "aarch64|arm64"
Line range hint
1-41
: Overall LGTM: Changes align with PR objectives and best practices.The changes made to this recipe are well-structured and align with the PR objectives of adding aarch64/arm64 builds. Here's a summary of the changes:
- Build number incremented correctly.
- Rust compiler requirement updated to use the Conda-forge compiler syntax.
- Additional platforms (linux-aarch64 and osx-arm64) added to support ARM architectures.
These changes follow Conda packaging best practices and should enable the package to be built and used on ARM-based systems.
To ensure the changes are fully effective, please perform the following final verifications:
- Confirm successful builds on all platforms, including the new ARM architectures.
- Verify that all dependencies are available for the new architectures.
- Run basic functionality tests on the ARM builds to ensure the package works as expected.
You can use the following command to get an overview of the build status across different platforms:
#!/bin/bash # Description: Check build status across different platforms gh run list --limit 1 --json conclusion,url --jq '.[] | select(.conclusion == "success") | .url' | xargs -I {} gh run view {} --log | grep -E "Build summary|linux-64|osx-64|linux-aarch64|osx-arm64"If all these checks pass, the PR should be ready for merging.
20-20
: LGTM: Rust compiler requirement updated correctly.Changing from
rust >=1.39
to{{ compiler("rust") }}
is a good practice. It allows for more flexibility and easier maintenance by letting the build system choose the appropriate Rust compiler version.To ensure this change doesn't introduce any compatibility issues, please verify that the package builds successfully with this new compiler specification. You can use the following command to check the build logs:
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
@BiocondaBot please add label |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
linux-aarch64
andosx-arm64
.gxf2bed
package.