Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated revision and enabled osx build #51176

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

kowallus
Copy link
Contributor

@kowallus kowallus commented Oct 5, 2024

update of pgrc version and recipe (added osx build)


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 5, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces several updates to the meta.yaml file for the pgrc package. The version number has been incremented from "2.0" to "2.0.1", and the SHA256 checksum has been updated accordingly. The build number has been modified from 1 to 0. Additionally, the directive to skip building on macOS has been removed, allowing for broader compatibility. The list of supported platforms has been expanded to include osx-arm64, enhancing the package's availability on different architectures. The overall structure of the meta.yaml file, including package information, source URL, requirements, test commands, and the about section, remains unchanged.

Possibly related PRs

  • pgrc: add linux-aarch64 build #51009: This PR updates the meta.yaml file for the pgrc package, incrementing the build number and adding support for linux-aarch64 and osx-arm64, which is directly related to the changes in the main PR that also added osx-arm64 to the additional platforms.
  • recipe for pgrc #50973: This PR introduces the initial meta.yaml for the pgrc package, which is relevant as it establishes the foundational configuration that the main PR builds upon by updating the version and other details in the same file.
  • gxf2bed: add aarch64/arm64 builds #51120: This PR adds support for linux-aarch64 builds in the gxf2bed recipe, which is relevant as it also involves modifications to the meta.yaml file to include additional platforms, similar to the changes in the main PR.

Suggested labels

please review & merge, osx-arm64

Suggested reviewers

  • martin-g

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 96fcc08 and 676902a.

📒 Files selected for processing (1)
  • recipes/pgrc/meta.yaml (3 hunks)
🧰 Additional context used
🪛 yamllint
recipes/pgrc/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (5)
recipes/pgrc/meta.yaml (5)

1-2: Version update approved, but please verify the date.

The version update to 2.0.1 is consistent with the PR objectives. However, the newly added date field is set to "2024-10-04", which is in the future.

Please confirm if this future date is intentional or if it should be adjusted to the current date.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


3-3: SHA256 checksum update looks good.

The SHA256 checksum has been updated, which is expected when updating to a new version of the package.


10-10: Build number reset approved.

Resetting the build number to 0 is correct when updating to a new version of the package. This change aligns with Bioconda best practices.


32-32: Please clarify the change in the test command.

The test command has been changed from checking the version to checking the date. While this might be related to the new date field added earlier, it's not clear why the date would be a better indicator of the correct version than the version number itself.

Could you please explain the rationale behind this change? Additionally, consider keeping a version check alongside the date check for more robust testing.


45-45: Addition of osx-arm64 platform approved.

The addition of 'osx-arm64' to the list of additional platforms aligns with the PR objective of enabling OSX build. This change extends support to ARM-based Mac systems, which is a positive improvement.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kowallus
Copy link
Contributor Author

kowallus commented Oct 5, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 5, 2024
@kowallus
Copy link
Contributor Author

kowallus commented Oct 5, 2024

ping @bioconda/core

@BiocondaBot
Copy link
Collaborator

Reposting for @kowallus to enable pings (courtesy of the BiocondaBot):

ping @bioconda/core

@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants