remove osx skip #52093
remove osx skip #52093
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/clair3/meta.yaml (2)
Line range hint
20-39: Consider updating dependency versions and adding constraintsSeveral concerns about the dependencies:
- Python 3.9.0 and OpenSSL 1.1.1 are older versions that might have security vulnerabilities
- Missing version constraints for numpy and pytables could lead to compatibility issues
- Consider using version ranges instead of strict pins for better flexibility
Consider:
- Updating Python to a more recent 3.9.x release
- Adding version constraints for numpy and pytables
- Using version ranges (e.g.,
>=3.9.0,<3.10) for better flexibility while maintaining compatibility
Line range hint
40-45: Enhance test coverage for macOS compatibilitySince we're enabling macOS builds, consider adding:
- Version checks in test commands
- Platform-specific tests if needed
- Validation of key functionalities
Add version checks to test commands:
test: imports: - tensorflow commands: - longphase --version - - which clair3.py + - clair3.py --version || true # Version check might exit with non-zero - run_clair3.sh -v
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/clair3/meta.yaml(1 hunks)
🔇 Additional comments (2)
recipes/clair3/meta.yaml (2)
Line range hint 18-19: Verify compiler compatibility for macOS
Since we're enabling macOS builds, ensure that:
- The C/C++ compiler requirements are properly satisfied on macOS
- Any platform-specific compiler flags or settings are addressed
#!/bin/bash
# Description: Check for any macOS-specific build instructions or compiler settings
# Search for any existing macOS-specific configurations in other recipes
rg -l "compiler\('c'\)|compiler\('cxx'\)" | xargs rg "osx|darwin" -C 513-13: Verify macOS dependency availability
The build number increment is appropriate for the changes. However, since we're enabling macOS builds by removing the skip directive, we should verify that all dependencies are available and compatible with macOS.
|
Thanks for helping out @mencian, I'm not actually sure if it is possible to run on macOS so I was just testing it out. My C/C++ isn't very strong wither so I can't be much help I'm afraid. |
Check if clair3 works on macOS
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.