Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Corneto #51745

Merged
merged 4 commits into from
Oct 29, 2024
Merged

add Corneto #51745

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60c181a
meta.yaml created by greyskull
nilchia Oct 28, 2024
d9c5a62
update meta.yaml
nilchia Oct 28, 2024
10decf5
Update recipes/corneto/meta.yaml
nilchia Oct 29, 2024
64e89d7
SPDX identifier
nilchia Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions recipes/corneto/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{% set name = "corneto" %}
{% set version = "1.0.0a0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/corneto-{{ version }}.tar.gz
sha256: 966d50762f92047ea4e5d1a136607f20ae9ec1d585530a24ad5c95e700b24180

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("corneto", max_pin="x.x.x") }}

Comment on lines +12 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider relaxing version pinning for alpha release

The current run_exports configuration with max_pin="x.x.x" creates a strict version constraint. For an alpha release, consider using a more relaxed pinning strategy (e.g., x.x) to allow for rapid iterations while maintaining compatibility.

  run_exports:
-    - {{ pin_subpackage("corneto", max_pin="x.x.x") }}
+    - {{ pin_subpackage("corneto", max_pin="x.x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("corneto", max_pin="x.x.x") }}
build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("corneto", max_pin="x.x") }}

requirements:
host:
- python >=3.9
- poetry-core >=1.0.0
- pip
run:
- python >=3.9
- numpy >=1.15,<2.0.0
- cvxpy-base >=1.5.0,<2.0.0
- scipy >=1.11.0,<2.0.0

test:
imports:
- corneto
commands:
- pip check
requires:
- pip
Comment on lines +30 to +36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage

While the basic import test is good, consider adding more comprehensive tests to verify functionality:

 test:
   imports:
     - corneto
   commands:
     - pip check
+    - python -c "import corneto; assert corneto.__version__ == '1.0.0a0'"
   requires:
     - pip

Committable suggestion was skipped due to low confidence.


about:
home: https://github.com/saezlab/corneto/
summary: 'CORNETO: A Unified Framework for Omics-Driven Network Inference'
license: GPL-3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SPDX identifiers

nilchia marked this conversation as resolved.
Show resolved Hide resolved
license_file: LICENSE

extra:
recipe-maintainers:
- nilchia
Loading