feat(parser): better control on JSX parsing #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #4718 will not alter performanceComparing Summary
|
ematipico
force-pushed
the
feat/jsx-everywhere
branch
from
097bb98 to
9c05474
Compare
arendjr
approved these changes
Dec 11, 2024
Conaclos
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4716
Closes #4385
Adds a new option called
jsxEverywhere- name not set on stone, feel free to bikeshed, this is the name adopted by rome years ago - insidejavascript.parser. When set totrue, JSX syntax is expected in.js/.mjsfiles. When set tofalse, it will result in a parsing error.The option is
trueby default, so it's not a breaking change for our existing users.Test Plan
I added a new test case in the JS parser.