feat(parser): better control on JSX parsing

.changeset/add_new_option_javascriptjsxeverywhere.md

@@ -0,0 +1,11 @@
+---
+cli: minor
+---
+
+# Add new option `javascript.parser.jsxEverywhere`
+
+This new option allows to control whether Biome should expect JSX syntax in `.js`/`.ts` files.
+
+When `jsxEverywhere` is set to `false`, having JSX syntax like `<div></div>` inside `.js`/`.ts` files will result in a **parsing error**.
+
+This option defaults to `true`.

crates/biome_configuration/src/javascript/mod.rs

@@ -26,7 +26,7 @@ pub struct JavascriptConfiguration {
     pub assists: JavascriptAssists,
 
     /// Parsing options
-    #[partial(type, bpaf(external(partial_javascript_parser), optional))]
+    #[partial(type, bpaf(pure(Default::default()), optional))]
     pub parser: JavascriptParser,
 
     /// A list of global bindings that should be ignored by the analyzers
@@ -39,32 +39,43 @@ pub struct JavascriptConfiguration {
     #[partial(bpaf(pure(Default::default()), hide))]
     pub jsx_runtime: JsxRuntime,
 
-    #[partial(type, bpaf(external(partial_javascript_organize_imports), optional))]
+    #[partial(type, bpaf(pure(Default::default()), optional))]
     pub organize_imports: JavascriptOrganizeImports,
 }
 
 #[derive(Clone, Debug, Default, Deserialize, Eq, Partial, PartialEq, Serialize)]
-#[partial(derive(Bpaf, Clone, Deserializable, Eq, Merge, PartialEq))]
+#[partial(derive(Clone, Deserializable, Eq, Merge, PartialEq))]
 #[partial(cfg_attr(feature = "schema", derive(schemars::JsonSchema)))]
 #[partial(serde(default, deny_unknown_fields))]
 pub struct JavascriptOrganizeImports {}
 
 /// Options that changes how the JavaScript parser behaves
-#[derive(Clone, Debug, Default, Deserialize, Eq, Partial, PartialEq, Serialize)]
-#[partial(derive(Bpaf, Clone, Deserializable, Eq, Merge, PartialEq))]
+#[derive(Clone, Debug, Deserialize, Eq, Partial, PartialEq, Serialize)]
+#[partial(derive(Clone, Deserializable, Eq, Merge, PartialEq))]
 #[partial(cfg_attr(feature = "schema", derive(schemars::JsonSchema)))]
 #[partial(serde(rename_all = "camelCase", default, deny_unknown_fields))]
 pub struct JavascriptParser {
     /// It enables the experimental and unsafe parsing of parameter decorators
     ///
     /// These decorators belong to an old proposal, and they are subject to change.
-    #[partial(bpaf(hide))]
     pub unsafe_parameter_decorators_enabled: bool,
 
     /// Enables parsing of Grit metavariables.
     /// Defaults to `false`.
-    #[partial(bpaf(hide))]
     pub grit_metavariables: bool,
+
+    /// When enabled, files like `.js`/`.ts` can contain JSX syntax. Defaults to `true`.
+    pub jsx_everywhere: bool,
+}
+
+impl Default for JavascriptParser {
+    fn default() -> Self {
+        Self {
+            jsx_everywhere: true,
+            grit_metavariables: false,
+            unsafe_parameter_decorators_enabled: false,
+        }
+    }
 }
 
 /// Indicates the type of runtime or transformation used for interpreting JSX.

crates/biome_js_analyze/src/lint/nursery/use_aria_props_supported_by_role.rs

@@ -28,7 +28,7 @@ declare_lint_rule! {
     ///
     /// ### Valid
     ///
-    /// ```js
+    /// ```jsx
     /// <>
     ///     <a href="#" aria-expanded />
     ///     <img alt="foobar" aria-hidden />

crates/biome_js_analyze/src/lint/style/use_self_closing_elements.rs

@@ -34,27 +34,27 @@ declare_lint_rule! {
     ///
     /// ### Valid
     ///
-    /// ```js
+    /// ```jsx
     /// <div />
     ///```
     ///
-    /// ```js
+    /// ```jsx
     /// <div>child</div>
     ///```
     ///
-    /// ```js
+    /// ```jsx
     /// <Component />
     ///```
     ///
-    /// ```js
+    /// ```jsx
     /// <Component>child</Component>
     ///```
     ///
-    /// ```js
+    /// ```jsx
     /// <Foo.bar />
     ///```
     ///
-    /// ```js
+    /// ```jsx
     /// <Foo.bar>child</Foo.bar>
     ///```
     ///

crates/biome_js_analyze/tests/plugin/preferObjectSpread.grit.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: preferObjectSpread.grit
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 Object.assign({}, foo);
 
 Object.assign({}, {foo: 'bar'});

crates/biome_js_analyze/tests/spec_tests.rs

@@ -125,7 +125,6 @@ pub(crate) fn analyze_and_snap(
     let parsed = parse(input_code, source_type, parser_options.clone());
     let root = parsed.tree();
 
-    //
     let options = create_analyzer_options(input_file, &mut diagnostics);
 
     let (_, errors) = biome_js_analyze::analyze(

crates/biome_js_analyze/tests/specs/a11y/noPositiveTabindex/reactCreateElementInvalid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: reactCreateElementInvalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 React.createElement("div", { tabIndex: '1' })
 React.createElement("div", { tabIndex: 1 })
 React.createElement("div", { tabIndex: +1 })
@@ -89,5 +90,3 @@ reactCreateElementInvalid.js:3:40 lint/a11y/noPositiveTabindex  FIXABLE  ━━
 
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/noPositiveTabindex/reactCreateElementValid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: reactCreateElementValid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 React.createElement("div", { tabIndex: '0' })
 React.createElement("div", { tabIndex: '-1' })
 React.createElement("div", { tabIndex: dynamic })
@@ -23,5 +24,3 @@ React.createElement("div", props)
 React.createElement("div", {})
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useAriaActivedescendantWithTabindex/invalid.js.snap

@@ -1,33 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: invalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 <div aria-activedescendant={someID} />;
 
 ```
-
-# Diagnostics
-```
-invalid.js:1:1 lint/a11y/useAriaActivedescendantWithTabindex  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! Enforce elements with aria-activedescendant are tabbable.
-
-  > 1 │ <div aria-activedescendant={someID} />;
-      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-    2 │ 
-
-  i aria-activedescendant is used to manage focus within a composite widget.
-    The element with the attribute aria-activedescendant retains the active document focus.
-
-  i Add the tabIndex attribute to the element with a value greater than or equal to -1.
-
-  i Unsafe fix: Add the tabIndex attribute.
-
-    1 │ <div·aria-activedescendant={someID}··tabIndex="0"·/>;
-      │                                    ++++++++++++++    
-
-```
-
-

crates/biome_js_analyze/tests/specs/a11y/useAriaActivedescendantWithTabindex/valid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: valid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 <CustomComponent />;
 <CustomComponent aria-activedescendant={someID} />;
 <CustomComponent aria-activedescendant={someID} tabIndex={0} />;
@@ -21,5 +22,3 @@ expression: valid.js
 <input aria-activedescendant={someID} tabIndex={-1} />;
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useButtonType/inObject.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: inObject.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 // invalid
 React.createElement('button');
 React.createElement('button', {

crates/biome_js_analyze/tests/specs/a11y/useButtonType/withBindingInvalid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: withBindingInvalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 import React, { createElement } from "react";
 
 React.createElement('button');
@@ -93,5 +94,3 @@ withBindingInvalid.js:13:13 lint/a11y/useButtonType ━━━━━━━━━
 
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useButtonType/withBindingValid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: withBindingValid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 import React, { createElement } from "notReact";
 
 React.createElement('button');
@@ -15,5 +16,3 @@ createElement('button', {
     "type": "bar"
 });
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useButtonType/withDefaultNamespaceInvalid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: withDefaultNamespaceInvalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 import * as DefaultNamespace  from "react";
 
 DefaultNamespace.createElement('button');
@@ -71,5 +72,3 @@ withDefaultNamespaceInvalid.js:8:13 lint/a11y/useButtonType ━━━━━━
 
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useButtonType/withRenamedImportInvalid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: withRenamedImportInvalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 import AwesomeReact, { createElement as awesomeCreateElement } from "react";
 
 AwesomeReact.createElement('button');
@@ -93,5 +94,3 @@ withRenamedImportInvalid.js:13:13 lint/a11y/useButtonType ━━━━━━━
 
 
 ```
-
-

crates/biome_js_analyze/tests/specs/a11y/useFocusableInteractive/invalid.js.snap

@@ -1,50 +1,13 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: invalid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 <div>
 	<div role="button" />
 	<div role="tab" />
 </div>;
 
 ```
-
-# Diagnostics
-```
-invalid.js:2:2 lint/a11y/useFocusableInteractive ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! The HTML element with the interactive role "button" is not focusable.
-
-    1 │ <div>
-  > 2 │ 	<div role="button" />
-      │ 	^^^^^^^^^^^^^^^^^^^^^
-    3 │ 	<div role="tab" />
-    4 │ </div>;
-
-  i A non-interactive HTML element that is not focusable may not be reachable for users that rely on keyboard navigation, even with an added role like "button".
-
-  i Add a tabIndex attribute to make this element focusable.
-
-
-```
-
-```
-invalid.js:3:2 lint/a11y/useFocusableInteractive ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! The HTML element with the interactive role "tab" is not focusable.
-
-    1 │ <div>
-    2 │ 	<div role="button" />
-  > 3 │ 	<div role="tab" />
-      │ 	^^^^^^^^^^^^^^^^^^
-    4 │ </div>;
-    5 │ 
-
-  i A non-interactive HTML element that is not focusable may not be reachable for users that rely on keyboard navigation, even with an added role like "tab".
-
-  i Add a tabIndex attribute to make this element focusable.
-
-
-```

crates/biome_js_analyze/tests/specs/a11y/useFocusableInteractive/valid.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: valid.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 <div>
 	<div role="button" tabIndex={0} />
 

crates/biome_js_analyze/tests/specs/complexity/noExcessiveCognitiveComplexity/booleanOperators.js.snap

@@ -1,9 +1,10 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
 expression: booleanOperators.js
+snapshot_kind: text
 ---
 # Input
-```jsx
+```js
 function booleanOperators() {
     if (a                                     // +1 for `if`
         && b && c                             // +1
@@ -30,5 +31,3 @@ booleanOperators.js:1:10 lint/complexity/noExcessiveCognitiveComplexity ━━
 
 
 ```
-
-