Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): biome resolution #492

Merged
merged 3 commits into from
Oct 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions editors/vscode/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { type ChildProcess, spawn } from "child_process";
import { type Socket, connect } from "net";
import { isAbsolute } from "path";
import { dirname, isAbsolute } from "path";
import { TextDecoder, promisify } from "util";
import {
ExtensionContext,
Expand All @@ -25,6 +25,7 @@ import { StatusBar } from "./statusBar";
import { setContextValue } from "./utils";

import resolveImpl = require("resolve/async");
import { createRequire } from "module";
import type * as resolve from "resolve";

const resolveAsync = promisify<string, resolve.AsyncOpts, string | undefined>(
Expand Down Expand Up @@ -243,16 +244,34 @@ async function getWorkspaceDependency(
outputChannel: OutputChannel,
): Promise<string | undefined> {
for (const workspaceFolder of workspace.workspaceFolders) {
const path = Uri.joinPath(
workspaceFolder.uri,
"node_modules",
".bin",
"biome",
);
// To resolve the @biomejs/cli-*, which is a transitive dependency of the
// @biomejs/biome package, we need to create a custom require function that
// is scoped to @biomejs/biome. This allows us to reliably resolve the
// package regardless of the package manager used by the user.
try {
const requireFromBiome = createRequire(
require.resolve("@biomejs/biome/package.json", {
paths: [workspaceFolder.uri.fsPath],
}),
);
const binaryPackage = dirname(
requireFromBiome.resolve(
`@biomejs/cli-${process.platform}-${process.arch}/package.json`,
),
);

if (await fileExists(path)) {
return path.fsPath;
const biomePath = Uri.file(
`${binaryPackage}/biome${process.platform === "win32" ? ".exe" : ""}`,
);

if (await fileExists(biomePath)) {
return biomePath.fsPath;
}
} catch {
return undefined;
}

return undefined;
}

window.showWarningMessage(
Expand Down Expand Up @@ -351,9 +370,8 @@ async function getSocket(
outputChannel: OutputChannel,
command: string,
): Promise<string> {
const process = spawn(`"${command}"`, ["__print_socket"], {
const process = spawn(command, ["__print_socket"], {
stdio: [null, "pipe", "pipe"],
shell: true,
});

const stdout = { content: "" };
Expand Down