Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG]: /components endpoint is empty using auto-deploy #342

Closed
fmigneault opened this issue Jun 14, 2023 · 1 comment · Fixed by #347
Closed

🐛 [BUG]: /components endpoint is empty using auto-deploy #342

fmigneault opened this issue Jun 14, 2023 · 1 comment · Fixed by #347
Labels
bug Something isn't working

Comments

@fmigneault
Copy link
Collaborator

Details

The /components endpoint is empty after auto-deploy:

{"components": []}

This does not happen when using pavics-compose.sh.

Originally posted by @mishaschwartz in #329 (comment)
@fmigneault fmigneault added the bug Something isn't working label Jun 14, 2023
@tlvu tlvu mentioned this issue Jun 14, 2023
Merged
@mishaschwartz
Copy link
Collaborator

It looks like the issue is that grep in the pavics/docker-compose-git:docker-18.09.7-compose-1.25.1 image does not support searching for multiple patterns that are separated by newlines (see: https://github.com/bird-house/birdhouse-deploy/blob/1.26.4/birdhouse/scripts/get-components-json.include.sh#L58-L59).

The fix would be to replace BIRDHOUSE_DEPLOY_COMPONENTS_LIST_KNOWN which currently looks like:

components/cowbird
components/monitoring
components/scheduler
components/weaver
config/canarie-api
... etc.

with

-e components/cowbird -e components/monitoring -e components/scheduler -e components/weaver -e config/canarie-api

which should work with all versions of grep.

I can make this change shortly.

@mishaschwartz mishaschwartz mentioned this issue Jun 15, 2023
Merged
mishaschwartz added a commit that referenced this issue Jun 16, 2023
@mishaschwartz
components/ endpoint displays intended information after auto-deploy (
4a03b71 
#347)

## Overview

Previously, the script that generates the content for the `components/`
endpoint was using a feature of `grep` that is not supported by all
versions of `grep`.
  
This meant that this script running in the auto-deployment docker
container was not able to properly parse the running components using
`grep`.

This fixes the issue by making the script compliant with all versions of
`grep`.

## Changes

**Non-breaking changes**

None: bugfix

**Breaking changes**

None

## Related Issue / Discussion

- Resolves #342 

## Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

components/ endpoint displays intended information after auto-deploy bird-house/birdhouse-deploy
2 participants
@mishaschwartz @fmigneault