-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components/
endpoint displays intended information after auto-deploy
#347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change it addresses specifically looks fine.
However, the components/
of the latest test instance of this PR also experiences the issue #339
@fmigneault that issue is fixed in #344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this annoying behavior.
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1684/Result : failure BIRDHOUSE_DEPLOY_BRANCH : fix-components-after-autoreload DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-46.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1201/NOTEBOOK TEST RESULTS |
Overview
Previously, the script that generates the content for the
components/
endpoint was using a feature ofgrep
that is not supported by all versions ofgrep
.This meant that this script running in the auto-deployment docker container was not able to properly parse the running components using
grep
.This fixes the issue by making the script compliant with all versions of
grep
.Changes
Non-breaking changes
None: bugfix
Breaking changes
None
Related Issue / Discussion
/components
endpoint is empty using auto-deploy #342Additional Information