Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components/ endpoint displays intended information after auto-deploy #347

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

mishaschwartz
Copy link
Collaborator

Overview

Previously, the script that generates the content for the components/ endpoint was using a feature of grep that is not supported by all versions of grep.

This meant that this script running in the auto-deployment docker container was not able to properly parse the running components using grep.

This fixes the issue by making the script compliant with all versions of grep.

Changes

Non-breaking changes

None: bugfix

Breaking changes

None

Related Issue / Discussion

Additional Information

@github-actions github-actions bot added ci/deployment Related to deployment utilities and scripts documentation Improvements or additions to documentation labels Jun 15, 2023
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change it addresses specifically looks fine.

However, the components/ of the latest test instance of this PR also experiences the issue #339

@mishaschwartz
Copy link
Collaborator Author

@fmigneault that issue is fixed in #344

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this annoying behavior.

@github-actions github-actions bot added the ci/operations Continuous Integration components label Jun 16, 2023
@mishaschwartz mishaschwartz merged commit 4a03b71 into master Jun 16, 2023
@mishaschwartz mishaschwartz deleted the fix-components-after-autoreload branch June 16, 2023 17:11
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1684/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-components-after-autoreload
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1201/

NOTEBOOK TEST RESULTS
    
[2023-06-16T18:01:14.837Z] ============================= test session starts ==============================
[2023-06-16T18:01:14.837Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-06-16T18:01:14.837Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-06-16T18:01:14.837Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-06-16T18:01:14.837Z] collected 245 items
[2023-06-16T18:01:14.837Z] 
[2023-06-16T18:01:23.527Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-06-16T18:01:31.395Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-06-16T18:01:39.474Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [  9%]
[2023-06-16T18:01:45.756Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 13%]
[2023-06-16T18:01:48.499Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 17%]
[2023-06-16T18:14:29.220Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 22%]
[2023-06-16T18:14:31.127Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 22%]
[2023-06-16T18:14:39.386Z] ...............                                                          [ 28%]
[2023-06-16T18:14:49.519Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 30%]
[2023-06-16T18:14:56.883Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .....F            [ 33%]
[2023-06-16T18:15:14.411Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 35%]
[2023-06-16T18:15:16.056Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 35%]
[2023-06-16T18:15:21.079Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 38%]
[2023-06-16T18:15:25.779Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 40%]
[2023-06-16T18:18:08.448Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 46%]
[2023-06-16T18:19:12.297Z] .............                                                            [ 52%]
[2023-06-16T18:19:17.371Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 53%]
[2023-06-16T18:19:19.595Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 57%]
[2023-06-16T18:19:36.635Z] .................                                                        [ 64%]
[2023-06-16T18:19:42.288Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 66%]
[2023-06-16T18:19:43.674Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 66%]
[2023-06-16T18:19:58.998Z] .FF......                                                                [ 70%]
[2023-06-16T18:20:09.479Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 74%]
[2023-06-16T18:20:19.092Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2023-06-16T18:20:20.473Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2023-06-16T18:20:24.031Z] ......                                                                   [ 80%]
[2023-06-16T18:20:34.034Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 80%]
[2023-06-16T18:20:48.937Z] .............                                                            [ 85%]
[2023-06-16T18:20:58.916Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2023-06-16T18:21:37.933Z] ....s.                                                                   [ 88%]
[2023-06-16T18:21:46.058Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-06-16T18:22:00.824Z] ...                                                                      [ 90%]
[2023-06-16T18:22:15.707Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2023-06-16T18:22:38.574Z] ......                                                                   [ 93%]
[2023-06-16T18:22:40.599Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-06-16T18:25:45.047Z] notebooks/stress-tests.ipynb .....                                       [100%]
[2023-06-16T18:25:45.047Z] 
[2023-06-16T18:25:45.047Z] =================================== FAILURES ===================================
    
  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/deployment Related to deployment utilities and scripts ci/operations Continuous Integration components documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG]: /components endpoint is empty using auto-deploy
4 participants