-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add re-usable Gradle task postBuild #1
Conversation
As I'm no big gradle expert -> @alvasw Could you please review this PR? Thanks! |
TODO Create new PR to change .gitmodules content [submodule "bisq-gradle"] path = bisq-gradle url = https://github.com/ghubstan/bisq-gradle.git branch = add-post-build-task TO [submodule "bisq-gradle"] path = bisq-gradle url = https://github.com/bisq-network/bisq-gradle.git We need to wait until PR bisq-network/bisq-gradle#1 to be approved & merged before making the above change to .gitmdoules
@alvasw @ripcurlx This See https://github.com/ghubstan/bisq-pricenode/blob/adjust-build-files-n-scripts/build.gradle |
@alvasw @ripcurlx I need to anticipate a couple of questions from either of you about this PR.
|
Hi @ghubstan!
Makes sense to me.
Did you push your attempt where you tried to use a precompiled script plugin somewhere? I can take a look at it if you want to. I think that it's cleaner. In Bisq 2, we're using and referencing precompiled script plugins. |
I deleted it, and just pushed it back & made you a collaborator: https://github.com/ghubstan/bisq-post-assemble-plugin What I couldn't get to work was its use in another repo, after making
The script itself is a mess (no matter, not the problem). This PR's |
I fixed it. Take a look at [1] for the changes in the plugin and at [2] on how to use it in other repositories. [1] https://github.com/ghubstan/bisq-post-assemble-plugin/tree/convert_to_standalone_plugin |
Closed, replaced by PR #2 |
Several new bisq-* repos are going to be pulled out of the large, multi-project bisq repo.
They must follow the parent repo's convention of copying startup scripts and jar lib directories into their respective repos' root directories. This repo's first shared script is task
postBuild
with description: "Makes distribution's start script runnable from project root directory."Usage is described in the repo's README.md.
Based on
main
.