-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bisq v1 post build plugin #2
Add bisq v1 post build plugin #2
Conversation
@ripcurlx @alvasw , I copied the task It works in this consuming bisq-pricenode project. I think the only important diffs are the standalone plugin project has gradlew scripts, so it can be compiled in its own project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Looks good, but there's a little mistake. You forgot to add the following snippet in the
It was also my bad not to remove it in the Proof of Concept. You can take a look at the Bisq 2 |
The consuming project (a different repo) does have the includeBuild: https://github.com/ghubstan/bisq-pricenode/blob/87a1decee7905b496d1db02f0d2d4df27c25adc2/settings.gradle#L3 So I'm a little confused... I think it's OK. |
Is being replaced by bisq-network's bisq-gradle plugin because PR bisq-network/bisq-gradle#2 has been merged.
You're calling Yeah, it works, and you don't have to change it. It's up to you. [1] https://docs.gradle.org/current/dsl/org.gradle.api.initialization.Settings.html#org.gradle.api.initialization.Settings:includeBuild(java.lang.Object) |
I see. My mistake. I will read about this and change it in another PR. |
We're including the `bisq-gradle` plugin build, not a project build, and we must call `includeBuild('bisq-gradle')` on the `PluginManagementSpec` DSL, not the `Settings` DSL. See https://docs.gradle.org/current/javadoc/org/gradle/plugin/management/PluginManagementSpec.html. Resolves bisq-network/bisq-gradle#2 (comment).
Define custom task
postBuild
in standalone Gradle plugin with IDbisq.post-build
.Task runs at end of importing project's
build
task to copy startup script and lib dir to root project directory.Replaces PR #1.