Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Optional additional information' field text on 'Cash by Mail' payment method to encourage traders to state the country they are located and the region / countries they are willing to accept offers from #5394

Closed
pazza83 opened this issue Apr 5, 2021 · 11 comments · Fixed by #5399

Comments

@pazza83
Copy link

pazza83 commented Apr 5, 2021

Description

'Cash by Mail' payment method allows traders to place and take offers from any location.

Some traders may only wish to trade with users from a particular region or country.

This has lead to at least a couple of 'Cash by Mail' trades entering mediation and being cancelled.

To avoid this I propose changing the 'Optional additional information' field text on 'Cash by Mail' payment method to encourage traders to state the country they are located and the region / countries they are willing to accept offers from

Version

1.6.2

Steps to reproduce

Go to > Accounts > National Currency accounts > Add new account > cash by mail

No prompt for country / region to be considered

Expected behaviour

Maker places offer to sell BTC via cash by mail and includes the countries they are located and the region they are willing to accept trades from.

Maker places offer to buy BTC via cash by mail and includes the countries they are located and the region they are willing to accept trades from.

Actual behaviour

No prompt for countries / regions.

Screenshots

cash by mail
Current screenshot

Text to change in (Optional additional information)

Change current text:
Define any special terms, conditions, or details, you would like to be displayed with your offers for this payment account (users will see this info before accepting offers).

to

Please state on your offers:

Country you are located (eg France):
Countries / regions you would accept trades from (eg France, EU, or any European country):
Any special terms/conditions:
Any other details:
@ghost
Copy link

ghost commented Apr 5, 2021

👍 Thanks, I will work on this.

@ghost
Copy link

ghost commented Apr 5, 2021

@pazza83 You chose an implementation that does not enforce the country restriction. I like it, not adding complexity etc. Probably some traders don't bother to read the offer details though. Do you think it is worth a popup at take offer stage to confirm that the trader has read the restrictions and accepts them? (a specific popup case for CashByMail only).

The alternative would be to enforce the country restriction by specifying country or region in a new field of the account and having that match in maker & taker. Harder to implement, but maybe more consistent?

@pazza83
Copy link
Author

pazza83 commented Apr 5, 2021

Hi @jmacxx

Yes I thought it would be best to not enforce the country restriction.

I didn't want to enforce country restriction as:

  • People could live in dependencies, autonomous Communities, or small nations like Monaco, Canary Islands, Isle of Mann and therefore have slightly different requirements.
  • People might have differing countries, regions, geographies they are willing to trade with.

The current text implies

(users will see this info before accepting offers).

I think a pop-up to confirm they have read this information would be great. Maybe include the information in the pop-up if this can be achieved?

@ghost
Copy link

ghost commented Apr 5, 2021

The popup verification showing the maker's specified restrictions seems to be the most flexible solution in this case.

(Some CashByMail sellers are asking for the ability to exclude New York residents due to BitLicense, that's another example of hard to implement restrictions).

@ghost
Copy link

ghost commented Apr 5, 2021

@pazza83 Trying this out with some existing open CashByMail offers and they have an awful lot of text in the Optional Additional Information field, it fills up the entire screen and even then only 75% is shown. On a smaller laptop display it would show only half as much as what's in this screenshot. Are there any other risks displaying user-entered data in this way?

Screenshot below:
image

@pazza83
Copy link
Author

pazza83 commented Apr 5, 2021

Hi @jmacxx

That does look like a lot of text.

Not sure what you mean by:

Are there any other risks displaying user-entered data in this way?

@ghost
Copy link

ghost commented Apr 5, 2021

Nevermind, we can display it in a readonly TextArea control which comes with a scrollbar.

@huey735
Copy link
Contributor

huey735 commented Apr 6, 2021

My intuition is that enough traders won't read the disclaimer and will take offers that they don't intend to follow through. However more difficult it may be, I prefer that we had a National Bank Transfer-like model where the trader can choose their country in the creation of the account.

@ghost
Copy link

ghost commented Apr 6, 2021

@huey735 The CashByMail terms will be shown with an "I CONFIRM" button they have to press before they can take the offer. That should make it pretty clear.

image

@huey735
Copy link
Contributor

huey735 commented Apr 6, 2021

Honestly the amount of popups in Bisq makes me close most of them without reading and any non-rigid rule is likely to not be followed.

@ghost
Copy link

ghost commented Apr 7, 2021

Discussed with @pazza83 and @huey735 in support team meeting and concluded that for now the initial/simpler solution proposed here is best, esepcially as CashByMail is a niche market. If traders end up ignoring the popup we can revisit and implement a hard account restriction by country.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants