Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CashByMail show terms and conditions upon taking an offer #5399

Merged
merged 1 commit into from Apr 12, 2021
Merged

CashByMail show terms and conditions upon taking an offer #5399

merged 1 commit into from Apr 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2021

Fixes #5394

A more explicit suggestion in CashByMail account creation, suggesting countries & other restrictions to be entered.

Maker's terms and conditions are then displayed to the taker who can then choose to continue with the trade or not after reviewing.

Since the terms and conditions can be quite long, a special popup window had to be used which contains a scrollable TextArea control. The GenericMessageWindow is written to be reusable for other features.

Copy link
Contributor

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit d8b42d7 into bisq-network:master Apr 12, 2021
@ripcurlx ripcurlx added this to the v1.6.3 milestone Apr 12, 2021
@BtcContributor
Copy link
Contributor

I would suggest to make the scroll slider more evident. It was not too clear to me that I could scroll.
In particular in Dark Mode, it is not visible at all, at least on my display.

Light Mode:
image

Dark Mode:
image

@ghost ghost mentioned this pull request May 4, 2021
@ghost ghost deleted the cashbymail_enhance_terms branch May 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants