Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bip-0044.mediawiki #76

Closed
wants to merge 1 commit into from

Conversation

jprichardson
Copy link

Add constants for Litecoin, Litecoin Testnet, Dogecoin, and Dogecoin Testnet

Add constants for `Litecoin`, `Litecoin Testnet`, `Dogecoin`, and `Dogecoin Testnet`
@jprichardson
Copy link
Author

Or even better... some deterministic way to generate the constants for each crypto currency? For sake of compatibility, keep Bitcoin/Testnet at 0 and 1 respectively.

@gavinandresen
Copy link
Contributor

"BIP" stands for "Bitcoin" improvement process.

This belongs in LIPS/DIPS, in my humble opinion. I don't want to get dragged into which coins deserve constants in BIPS and which ones don't.....

@jprichardson
Copy link
Author

"BIP" stands for "Bitcoin" improvement process.

Yup.

Coin type is a constant, set for each cryptocoin. Cryptocoin developers may ask for registering unused number for their project.

The list of already allocated coin types is in the chapter "Registered coin types" below.

Might I suggest removing the aforementioned then? Perhaps the entire Coin Type section? Or make a statement about delegating the constants to the authority/developers of each respective crypto currency?

@laanwj
Copy link
Member

laanwj commented Jun 25, 2014

Agree with @gavinandresen here. Maintaining a list of altcoins is outside of the scope of BIPs.

Let's just leave ours (bitcoin and bitcoin testnet) specified, and leave the rest up to developers of altcoins themselves.

@prusnak
Copy link
Contributor

prusnak commented Jul 9, 2014

@jprichardson We can talk about assigning particular numbers when there already is a working BIP44 wallet for coin. Then you can ask for assigning a coin type into this document: https://github.com/satoshilabs/docs/blob/master/slips/slip-0044.rst

Which is regularly deployed here: http://doc.satoshilabs.com/slips/

@dcousens
Copy link
Contributor

dcousens commented Jul 9, 2014

Is there any reason not to use a deterministic process for this instead of a centralized register?
I understand we are currently constrained to 31 bits and truncating SHA256('bitcoin') or SHA256('litecoin') is probably less than ideal.

But we are only constrained to that if we continue to separate coins using a derivation index, instead you could embed the separation into the derivation process.

Perhaps data = serP(point(kpar)) || ser32(index) || 'bitcoin' would be simpler?

@prusnak
Copy link
Contributor

prusnak commented Jul 9, 2014

@dcousens your second idea seems ok, but i'm afraid it's too late to change it now

@dcousens
Copy link
Contributor

dcousens commented Jul 9, 2014

@prusnak why is it too late?

This is still a draft, and I'd argue the centralization of constants through a 3rd party arbitrator is a critical flaw.

@jprichardson
Copy link
Author

@dcousens your second idea seems ok, but i'm afraid it's too late to change it now

Why is it too late to change it now? As far as I can tell, BIPs change frequently, and since this is in the draft stage, what could it hurt to change it to something that makes more sense?

@prusnak
Copy link
Contributor

prusnak commented Jul 9, 2014

Because the change involves changing BIP-0032 which is Accepted for quite some time. That also means this is not the right thread to propose the change.

@dcousens
Copy link
Contributor

dcousens commented Jul 9, 2014

Out of interest, why was the BIP32 constant Bitcoin seed not changed?
It seems like it was the most straight forward and intended value to change to enable a cross-currency BIP32 implementations using a single master seed.

Was it purely to adhere with BIP43?

@luke-jr
Copy link
Member

luke-jr commented Jul 9, 2014

BIPs are Bitcoin Improvement Proposals; "cross-currency" isn't a goal. (altcoins that wish to use Bitcoin-designed protocols are free to make appropriate changes without worrying about the BIP specification)

@dcousens
Copy link
Contributor

dcousens commented Jul 9, 2014

@luke-jr I don't disagree, yet this BIP centralizes entirely around a coin_type.

Coin type is a constant, set for each cryptocoin. Cryptocoin developers may ask for registering unused number for their project.

@dcousens
Copy link
Contributor

@prusnak it doesn't involve changing BIP32, it involves changing this BIPs use/implementation of BIP32.

@prusnak
Copy link
Contributor

prusnak commented Jul 10, 2014

@dcousens right. but this is still something i would not rather do as it breaks compatibility with BIP32 and has couple of other disadvantages when it comes to implementation.

@dcousens
Copy link
Contributor

@prusnak what are the disadvantages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants