Revert "Removed -nostdlib from LDFLAGS" #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af0cbe5. `-nostdlib` was added to LDFLAGS when we converted to kbuild. PR #1310 removed -nostdlib in order to make it possible to use the `atof()` function. However, this now causes similar linker warnings to those it was trying to solve (discussion 784). 420 days later, `atof()` is not being used anywhere internally. Discussion in #1299 is not very conclusive on why this is needed. The arguing mostly relies that the cost in flash and RAM is so low that there is no good reason not to do it. There is now!
ToveRumar
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit af0cbe5.
-nostdlibwas added to LDFLAGS when we converted to kbuild. PR #1310 removed-nostdlibin order to make it possible to use theatof()function. However, this now causes similar linker warnings to those it was trying to solve (discussion 784). From what I can tell this occurs with newer version of newlib on e.g. Ubuntu 24.04.420 days later,
atof()is not being used anywhere internally. Discussion in #1299 is not very convincing on whyatof()is needed. The arguing mostly relies that the cost in flash and RAM is so low that there is no good reason not to do it. However, it now causes linker warnings.This PR fixes the linker warnings by reverting this commit. It comes with a bonus reduced flashed and RAM usage, but at a cost of losing the
atof()fn.I haven't been able to find a way, but am open to suggestions that preserve
atof()functionality.