Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Removed -nostdlib from LDFLAGS" #1419

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Revert "Removed -nostdlib from LDFLAGS" #1419

merged 1 commit into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Revert "Removed -nostdlib from LDFLAGS" 

    This reverts commit af0cbe5.

`-nostdlib` was added to LDFLAGS when we converted to kbuild.
PR #1310 removed -nostdlib in order to make it possible to use the `atof()` function.
However, this now causes similar linker warnings to those it was trying to solve (discussion 784).
420 days later, `atof()` is not being used anywhere internally. Discussion in #1299 is not very conclusive on why this is needed. The arguing mostly relies that the cost in flash and RAM is so low that there is no good reason not to do it. There is now!
    @gemenerik
    gemenerik committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    af6adcc View commit details
    Browse the repository at this point in the history