Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GH Actions to use Nodejs
v20
Context: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Our current warnings: https://github.com/bitfinexcom/bfx-report-electron/actions/runs/7913595670
Basic changes:
coactions/setup-xvfb
gh action to exact commit to have required nodejs ver under hood: resolved here Use node20 coactions/setup-xvfb#23beta
releasesTODO:
dorny/test-reporter
does not still supportactions/upload-artifact@v4
required for Nodejs 20 migration. And to uploadtest reports
needs to usev3
with Nodejs v16 which will show one related warning actions/upload-artifact & actions/download-artifact v4 support dorny/test-reporter#363So here we are waiting for
dorny/test-reporter
changes to have the last resolvedNo breaking changes here and can be merged freely
Everything has been tested on own fork: