Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh actions to use nodejs v20 #344

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Mar 13, 2024

This PR adds the last part of the previous #323 updates GH Actions to use Nodejs v20


Context: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Our current warnings: https://github.com/bitfinexcom/bfx-report-electron/actions/runs/8169998113


Solution:

  • as dorny/test-reporter GH Action is stuck with the update to support actions/upload-artifact@v4
  • turns off downloading test results managed dorny/test-reporter with removing artifact options
  • adds additional downloading step before dorny/test-reporter using actions/download-artifact@v4 actions
  • and after all, we can use actions/upload-artifact@v4 everywhere

Notes:

  • after opening PR against master the unit tests will be triggered, but Test Report will fail because the GH Actions don't want to take the last incoming changes of the corresponding workflow file and uses already existing changes in the master branch that are incompatible. And after merging in the next release iteration, everything should work as expected
  • the first release launch
    Screenshot from 2024-03-13 08-25-46
  • the next release launch
    Screenshot from 2024-03-13 08-26-44

@ZIMkaRU ZIMkaRU closed this Mar 13, 2024
@ZIMkaRU ZIMkaRU reopened this Mar 13, 2024
@ZIMkaRU ZIMkaRU changed the base branch from master to staging March 13, 2024 07:40
Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 006ea5a into bitfinexcom:staging Mar 13, 2024
2 checks passed
This was referenced Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants