make installation easier (goreleaser) #134
Comments
|
I agree we should switch to In the meantime, there is now a homebrew recipe for We should absolutely document that in the README installation section, because macOS users expect to be spoonfed |
|
Had a go at a PR... don't mind github snitching on me.. 😅 |
140: GoReleaser build and release support r=anguslees a=kskewes GoReleaser build and release support Simplified build (and release?) per #134. Not automatically hooked into Travis or anything (yet). **Binaries tested with `--version`:** - linux (docker images as well) - windows **Binaries not tested:** - darwin (don't have mac) **Build and Publish tested:** - Create [GitHub Token](https://goreleaser.com/environment/) - In `.goreleaser.yml` comment out `release.disable: true` - `git commit` - `git tag v0.7.1 && git push` - `make publish` - single archive per platform contains both `controller` and `kubeseal` binaries, plus kubernetes yaml's - locally docker images are created **Not Tested:** - docker image push - In `.goreleaser.yml` comment out `docker.skip_push: true` **Build fork/dirty/etc:** (assuming merged, patch on upstream or blog link below) ``` make snapshot ``` This results in binaries, archives and docker images tagged with full git commit hash. **To Do:** - [x] TODO: comment added for brew to change to [published formula](https://github.com/Homebrew/homebrew-core/blob/master/Formula/kubeseal.rb) - [x] confirm ok publishing archive instead of binaries - [x] yamls added to archive - [x] DOCS update and simplification First time using goreleaser so... :) Co-authored-by: Karl Skewes <karl.skewes@gmail.com> Co-authored-by: Karl <karl.skewes@gmail.com>
|
I apologize for the dumb question, but I am on Windows 10 and don't know how to install. Any documentation I can refer to? I have not used goreleaser before, and it seems like support for it was maybe reverted? Any help would be greatly appreciated. |
|
Yes the PR was reverted and replacement submitted. |
|
(sorry for the slowness on this I'm dealing with higher prio stuff first) Now the installation instructions mention brew for macos, and we even have a badge that should indicate how much the homebrew release lags behind out latest github release: @scottrigby, do you think it still makes sense to have a tap now that we have a formula in the main repo? I'm not very familiar with brew (despite being a macos user myself). Would a tap allow us to release (almost) atomically with the main release? I noticed that the binary installed with $ kubeseal --version
kubeseal version:
``
What are the other practical differences? |
|
We adopted Goreleaser at #668 |
Problem
Installation is not straightforward enough for some users.
Suggestion
Use goreleaser (with a homebrew option for mac users, etc). The resulting installation section of your readme could then look something like this (you're not using dep, so the instructions would be even simpler, although… separate issue, but it may be fun to stop including the vendor dir directly - it'd make PRs a lot easier to review when deps need to change!).
It's pretty straightforward so I'm sure you don't need help, but 'm happy to pitch in if you think that'd be fun.
CC @anguslees & @jbeda 😄 👋
The text was updated successfully, but these errors were encountered: