-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoReleaser build and release support v2 #150
Conversation
@@ -57,9 +59,10 @@ controller.image: docker/Dockerfile docker/controller | |||
$(KUBECFG) show -V CONTROLLER_IMAGE=$(CONTROLLER_IMAGE) -o yaml $< > $@.tmp | |||
mv $@.tmp $@ | |||
|
|||
controller.yaml: controller.jsonnet controller.image controller-norbac.jsonnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controller.image
target breaks GoReleaser.
Remove from here but add to .travis.yml
to make up for it.
Simplified build (and release?) per #134. Not automatically hooked into Travis (yet). **Binaries tested with `--version`:** - linux (docker images as well) - windows **Binaries not tested:** - darwin (don't have mac) **Build and Publish tested:** - Create [GitHub Token](https://goreleaser.com/environment/) - In `.goreleaser.yml` comment out `release.disable: true` - `git commit` - `git tag v0.7.1 && git push` - `make publish` - single archive per platform contains both `controller` and `kubeseal` binaries, plus kubernetes yaml's - locally docker images are created **Not Tested:** - docker image push **Build fork/dirty/etc:** (assuming merged, patch on upstream or blog link below) ``` make snapshot ``` This results in binaries, archives and docker images tagged with full git commit hash. **To Do:** - [x] TODO: comment added for brew to change to [published formula](https://github.com/Homebrew/homebrew-core/blob/master/Formula/kubeseal.rb) - [x] confirm ok publishing archive instead of binaries - [x] yamls added to archive - [x] DOCS update and simplification - At a future time remove references to v0.70
Goreleaser now supports multiple archives and specifying which build artifact(s) go into which archive(s). In our |
Changed archive to only include Can update |
I see that a Windows build has been added to Travis now and available in the latest Release Candidate. Good stuff. |
I created the release manually. It's relatively easy to cross-compile Go. That said, I'd love to have some automation. |
Indeed, same with |
Let's revisit if required later. |
Simplified build (and release?) per #134.
Not automatically hooked into Travis (yet).
Binaries tested with
--version
:Binaries not tested:
Build and Publish tested:
git commit
git tag v0.80 && git push
make publish
controller
andkubeseal
binaries, plus kubernetes yaml'sNot Tested:
Build fork/dirty/etc: (assuming merged, patch on upstream)
This results in binaries, archives and docker images tagged with full git commit hash.
To Do: