Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip rewriting values.yaml #150

Closed
wants to merge 2 commits into from

Conversation

LP0101
Copy link

@LP0101 LP0101 commented Apr 4, 2022

Added a flag to skip rewriting the values.yaml

Usage:

--skip-values: Prevent charts-syncer from rewriting the image paths in values.yaml

Solves #104

@jotadrilo
Copy link
Contributor

Hello @LP0101, thanks for your contribution.

However, we would like to handle this issue using #153. The main reason is that, while this feature enables skipping the values rewrite via CLI, #153 enables skipping the container registry target definition. This is scoped and enough to fix #104 while it gives room to modify any, possibly, setting in the values YAML file unrelated to the container registry.

Sounds good?

@jotadrilo jotadrilo closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants