Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip change the value.yaml #153

Merged
merged 1 commit into from
May 9, 2022
Merged

Skip change the value.yaml #153

merged 1 commit into from
May 9, 2022

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Apr 25, 2022 •
edited
Loading

Skip change the value.yaml if not set

  # The bitnami charts use docker as default container registry. Let's switch
  # to one of their mirrors to ensure the container references reallocation works.
  #
  # NOTE: This does not reallocate container artifacts, actually, but their
  #       references in the chart.
  containerRegistry: gcr.io
  containerRepository: bitnami-containers

reslove : #104

@yankay yankay mentioned this pull request Apr 25, 2022
Merged
jotadrilo
jotadrilo reviewed Apr 25, 2022
View reviewed changes
api/config.go
Comment on lines +24 to +29
// if c.GetTarget().GetContainerRegistry() == "" {
// return errors.Errorf(`"target.containerRegistry" cannot be empty`)
// }
// if c.GetTarget().GetContainerRepository() == "" {
// return errors.Errorf(`"target.containerRepository" cannot be empty`)
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fully delete these lines?

@jotadrilo
Copy link
Contributor

thanks for your contribution!

@jotadrilo jotadrilo mentioned this pull request Apr 26, 2022
Closed
@jotadrilo
Copy link
Contributor

@yankay let me know if you can apply the requested changes!

@jotadrilo
Copy link
Contributor

Hello @yankay I will merge your PR and apply some changes separatelly. Thank you for your contribution!

@jotadrilo jotadrilo merged commit b0f01d5 into bitnami:master May 9, 2022
jotadrilo added a commit that referenced this pull request May 9, 2022
@jotadrilo
feat: Follow up on #153
2ab4267 
Signed-off-by: Joseda Rios <jdrios@vmware.com>
This was referenced May 9, 2022
Merged
Closed
jotadrilo added a commit that referenced this pull request May 9, 2022
@jotadrilo
feat: Follow up on #153
e4cc24c 
Signed-off-by: Joseda Rios <jdrios@vmware.com>
jotadrilo added a commit that referenced this pull request May 9, 2022
@jotadrilo
feat: Follow up on #153 (#157)
4cdb469 
Signed-off-by: Joseda Rios <jdrios@vmware.com>
@yankay
Copy link
Contributor Author

yankay commented Jul 6, 2022

Hello @yankay I will merge your PR and apply some changes separatelly. Thank you for your contribution!

Thanks @jotadrilo very much. Sorry for my late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotadrilo jotadrilo jotadrilo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yankay @jotadrilo