[bitnami/kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version #21489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
carrodher
added
verify
FraPazGal
added
on-hold
|
The issue has now been solved and the PR #21431 merged, could you please update this PR with the changes in |
FraPazGal
added
in-progress
and removed
on-hold
FraPazGal
requested review from
FraPazGal
and removed request for
CeliaGMqrz
…m chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
@FraPazGal done! |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
@FraPazGal please re-check! |
jani888
pushed a commit
to jani888/charts
that referenced
this pull request
Jan 19, 2024
…each helm chart version (bitnami#21489) * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: János Hidvégi <jani.hidvegi@gmial.com>
anthosz
pushed a commit
to anthosz/charts
that referenced
this pull request
Jan 23, 2024
…each helm chart version (bitnami#21489) * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
grouvie
pushed a commit
to grouvie/charts
that referenced
this pull request
Jan 25, 2024
…each helm chart version (bitnami#21489) * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
joancafom
pushed a commit
to dalbani/charts
that referenced
this pull request
Feb 22, 2024
…each helm chart version (bitnami#21489) * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
amorey
pushed a commit
to kubetail-org/helm-charts
that referenced
this pull request
Mar 1, 2024
* Avoid unnecessary restarts at new helm version: The ConfigMap where the config is stored, contains labels. The labels contains the version of the helm chart. If there is a new helm chart version, the pod gets restarted, too. It doesnt matter, if its necessary or not. To solve this, I moved the config to a named templated which can be sourced from the config map and the hash annotation. I contribute this pattern to many helm charts: ([promtail] Avoid unnecessary pod restart on each helm chart version grafana/helm-charts#2833, [bitnami/kubernetes-event-exporter] Avoid unnecessary pod restart on each helm chart version bitnami/charts#21489, [prometheus-blackbox-exporter] Avoid unnecessary pod restart on each helm chart version prometheus-community/helm-charts#4077, helm: Avoid unnecessary pod restart on each helm chart version kubernetes-sigs/external-dns#4103) * Added securityContexts to container and pod. They contains the current best-practice. The settings are required to run kubelint together with PSA restricted. * Added automountServiceAccountToken to the Deployment and ServiceAccount. A lot of security tools hightlight automountServiceAccountToken=true on a ServiceAccount as insecure. The best-practice is to set automountServiceAccountToken=false on a ServiceAccount and do automountServiceAccountToken=true on the Deployment. Ref: https://securecloud.blog/2021/08/17/azure-aks-reviewing-recommendations-from-security-center-disabling-automounting-api-credentials * Added nodeSelector, affinity, tolerations, priorityClassName Pass .Values.config, .Values.ingress.hosts.hosts through helm tpl function: If kubelint is part of a bigger umbrella helm chart, values from .Values.global can be re-used. It's also useful for the namespace option * Adds configurable readinessProbe to deployment * Bumps chart version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes the the input of the config checksum which triggers the reload.
On main branch, the whole configmap/secret checksum is included as checksum input. The configmap contains labels which includes the helm chart version. Each new helm chart version forces a pod restart which is not always necessary.
Benefits
Avoid unnecessary pod restart on each new helm chart version
Possible drawbacks
N/A
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm