Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General chart improvements #13

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

jkroepke
Copy link
Contributor

Hi,

I added many options to this helm chart now. Some of them base on good-pratice. Taken from other helm charts.

If you feel, this is too big, I will cut them into smaller PRs.

Non-resolved issues:

  • There is no readinessProbe, but some enterprise policy may require one. It doesn't matter if it make sense, rule is rule.
  • The Cookie Secret are stored inside a ConfigMap, but they should be stored inside a Kubernetes secret (any mount them via ENV variable. I can provide this in a follow-up PR.

I have tested the helm chart with helm upgrade kubetail . --set rbac.namespaced=false, helm upgrade kubetail . --set rbac.namespaced=true --set-string config.namespace='\{\{ .Release.Namespace \}\}

@jkroepke
Copy link
Contributor Author

I also see that some CI tests are missing. I highly recommed something like this:

https://github.com/jkroepke/helm-charts/blob/main/.github/workflows/lint-test.yaml

which automaticly does some lint check, spin-up a kubernetes cluster (inside GH Actions) check, if the helm chart is apply-able.

@amorey
Copy link
Member

amorey commented Feb 29, 2024

Thanks! Looks great! I'll do a deep dive tomorrow and get back to you with questions/suggestions. I'd definitely love a follow-up that improves secret handling!

@amorey
Copy link
Member

amorey commented Mar 1, 2024

Thank you, these modifications are very helpful. To simplify the PR and get the other changes merged more quickly, I think we should split out the rbac modifications and handle that separately. I'll add some other minor questions/suggestions inline.

There is no readinessProbe, but some enterprise policy may require one. It doesn't matter if it make sense, rule is rule.

We can use the kubetail /healthz endpoint for the readiness probe too. Currently there's no distinction between readiness/liveness in terms of healthz though we could modify this in the future if necessary.

The Cookie Secret are stored inside a ConfigMap, but they should be stored inside a Kubernetes secret (any mount them via ENV variable. I can provide this in a follow-up PR.

YES please!

charts/kubetail/values.yaml Outdated Show resolved Hide resolved
@jkroepke
Copy link
Contributor Author

jkroepke commented Mar 1, 2024

think we should split out the rbac modifications and handle that separately

Done

We can use the kubetail /healthz endpoint for the readiness probe too.

Thanks, Implemented.

@amorey amorey merged commit e00efaa into kubetail-org:main Mar 1, 2024
@jkroepke jkroepke deleted the chart-imporvements branch March 1, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants