Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/milvus] Fix milvus externalS3 config, address minor typos #27140

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

rajan123456
Copy link
Contributor

Description of the change

Fix Milvus connection with S3 when using externalS3 model

Benefits

Fix bug and increase usability

Possible drawbacks

NA

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: rajan123456 <rajan0493@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 14, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 14, 2024
@github-actions github-actions bot removed the request for review from carrodher June 14, 2024 07:22
@github-actions github-actions bot requested a review from dgomezleon June 14, 2024 07:22
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing

@dgomezleon dgomezleon merged commit e6c70d5 into bitnami:main Jun 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milvus solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/milvus] Cannot connect milvus with externalS3
4 participants