Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/milvus] Fix milvus externalS3 config, address minor typos #27140

Merged
merged 3 commits into from
Jun 14, 2024
Merged

[bitnami/milvus] Fix milvus externalS3 config, address minor typos #27140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a389fa9
[bitnami/milvus] Fix milvus externalS3 config, address minor typos
rajan123456 Jun 13, 2024
5748117
Update CHANGELOG.md
bitnami-bot Jun 13, 2024
c0ac1c6
Update CHANGELOG.md
bitnami-bot Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bitnami/milvus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Changelog

## 8.2.2 (2024-06-12)
## 8.2.3 (2024-06-14)

* [bitnami/milvus] Release 8.2.2 ([#27115](https://github.com/bitnami/charts/pull/27115))
* [bitnami/milvus] Fix milvus externalS3 config, address minor typos ([#27140](https://github.com/bitnami/charts/pull/27140))

## <small>8.2.2 (2024-06-12)</small>

* [bitnami/milvus] Release 8.2.2 (#27115) ([6e4fd91](https://github.com/bitnami/charts/commit/6e4fd9138237cb84c50b77427aa37c7a69ca4975)), closes [#27115](https://github.com/bitnami/charts/issues/27115)

## <small>8.2.1 (2024-06-12)</small>

Expand Down
2 changes: 1 addition & 1 deletion bitnami/milvus/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ maintainers:
name: milvus
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/milvus
version: 8.2.2
version: 8.2.3
4 changes: 2 additions & 2 deletions bitnami/milvus/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@ externalEtcd:

### External S3 support

You may want to have mastodon connect to an external storage streaming rather than installing MiniIO(TM) inside your cluster. To achieve this, the chart allows you to specify credentials for an external storage streaming with the [`externalS3` parameter](#parameters). You should also disable the MinIO(TM) installation with the `minio.enabled` option. Here is an example:
You may want to have Milvus connect to an external storage streaming rather than installing MiniIO(TM) inside your cluster. To achieve this, the chart allows you to specify credentials for an external storage streaming with the [`externalS3` parameter](#parameters). You should also disable the MinIO(TM) installation with the `minio.enabled` option. Here is an example:

```console
minio.enabled=false
externalS3.host=myexternalhost
exterernalS3.accessKeyID=accesskey
externalS3.accessKeyID=accesskey
externalS3.accessKeySecret=secret
```

Expand Down
2 changes: 1 addition & 1 deletion bitnami/milvus/templates/externals3-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
SPDX-License-Identifier: APACHE-2.0
*/}}

{{- if and (not .Values.minio.enabled) (not .Values.externalS3.existingSecret) .Values.enableS3 }}
{{- if and (not .Values.minio.enabled) (not .Values.externalS3.existingSecret) .Values.externalS3 }}
apiVersion: v1
kind: Secret
metadata:
Expand Down
2 changes: 1 addition & 1 deletion bitnami/milvus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5262,7 +5262,7 @@ externalEtcd:
##
keyPassword: ""
## @section External S3 parameters
## All of these values are only used when redis.enabled is set to false
## All of these values are only used when minio.enabled is set to false
## @param externalS3.host External S3 host
## @param externalS3.port External S3 port number
## @param externalS3.accessKeyID External S3 access key ID
Expand Down
Loading