-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eth #2281
Merged
Merged
Eth #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on: |
justinkook
commented
Aug 12, 2019
justinkook
commented
Aug 12, 2019
justinkook
commented
Aug 12, 2019
justinkook
commented
Aug 12, 2019
justinkook
commented
Aug 12, 2019
Can now sync ETH and get wallet history for ERC20 tokens
ETH blocks were using the BTC transforms, fixed that
justinkook
force-pushed
the
eth
branch
2 times, most recently
from
August 23, 2019 18:21
261287a
to
4e6d8ee
Compare
Gamboster
reviewed
Aug 27, 2019
…iming Making the websocket tests more stable
remove b-lib and b-lib-cash from package.json
justinkook
force-pushed
the
eth
branch
2 times, most recently
from
September 4, 2019 19:13
ee8ada7
to
bcc514d
Compare
[Feat] Check if valid API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BWC/BWS eth changes with key class MR and also ETH bitcore-node module changes.
Now includes ETH insight changes.
Uses mainly crypto-wallet-core for eth functionality.
Copay Set Up
Bitcore
npm i
inbitcore/
root directory.rm -rf node_modules package-lock.json
inbitcore/packages/bitcore-wallet-client/
directory.npm i
insidebitcore/packages/bitcore-wallet-client/
to install the NPM Registry versions of packages.Copay
rm -rf node_modules package-lock.json
insidecopay/
to remove old versions of bitcore-wallet-client.bash pack-all.sh
insidecopay/
to install local bitcore-wallet-client.Status:
{ fee: gasPrice }
from util.buildTx and txproposal.buildTx once CWC fix is published to npm.Requirements:
The following config flags are needed in the alias:
alias parity-test="parity --config dev --jsonrpc-cors=all --ws-origins=all --ws-apis=all --tracing on --base-path '/Users/justin/blockchains/dev/'"
More information on parity config:
https://wiki.parity.io/Configuring-Parity-Ethereum
bitcore.config.json
Steps to set up eth branch:
packages/bitcore-wallet-service/src/config.ts
packages/bitcore-wallet-service/src/lib/blockchainexplorer.ts
Test on Copay using this PR:
https://github.com/bitpay/copay/pull/9966
To see BWC/BWS changes only:
micahriggan#24