Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth #2281

Merged
merged 47 commits into from
Sep 17, 2019
Merged

Eth #2281

merged 47 commits into from
Sep 17, 2019

Conversation

justinkook
Copy link
Contributor

@justinkook justinkook commented Jul 18, 2019

BWC/BWS eth changes with key class MR and also ETH bitcore-node module changes.

Now includes ETH insight changes.

Uses mainly crypto-wallet-core for eth functionality.

Copay Set Up

Bitcore

  1. npm i in bitcore/ root directory.

  2. rm -rf node_modules package-lock.json in bitcore/packages/bitcore-wallet-client/ directory.

This is to remove symlinks / lerna bootstrap npm packages inside bitcore-wallet-client.

  1. npm i inside bitcore/packages/bitcore-wallet-client/ to install the NPM Registry versions of packages.

Copay

  1. rm -rf node_modules package-lock.json inside copay/ to remove old versions of bitcore-wallet-client.

  2. bash pack-all.sh inside copay/ to install local bitcore-wallet-client.

Status:

  • Need to remove { fee: gasPrice } from util.buildTx and txproposal.buildTx once CWC fix is published to npm.

Requirements:

  1. Parity dev chain:

--tracing on flag is required for internal contract transactions.

The following config flags are needed in the alias:

  • alias parity-test="parity --config dev --jsonrpc-cors=all --ws-origins=all --ws-apis=all --tracing on --base-path '/Users/justin/blockchains/dev/'"

More information on parity config:
https://wiki.parity.io/Configuring-Parity-Ethereum

  1. Add ETH to bitcore.config.json
"ETH": {
        "mainnet": {
          "provider": {
            "host": "127.0.0.1",
            "protocol": "ws",
            "port": 8546
          },
          "trustedPeers": [
            {
              "host": "127.0.0.1",
              "port": 30303
            }
          ]
        },

Steps to set up eth branch:

  1. Make eth point to local bitcore-node.
    packages/bitcore-wallet-service/src/config.ts
eth: {
      livenet: {
        url: 'http://localhost:3000',
      },
      testnet: {
        url: 'http://localhost:3000',
      },
  1. Point eth provider to local bitcore-node.
    packages/bitcore-wallet-service/src/lib/blockchainexplorer.ts
  eth: {
      livenet: 'http://localhost:3000',
      testnet: 'http://localhost:3000'
    }

Test on Copay using this PR:
https://github.com/bitpay/copay/pull/9966

To see BWC/BWS changes only:
micahriggan#24

@matiu
Copy link
Contributor

matiu commented Aug 12, 2019

Depends on:
#2325

…iming

Making the websocket tests more stable
remove b-lib and b-lib-cash from package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants